You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@cloudera.com> on 2013/06/19 01:54:36 UTC
Review Request: SQOOP-1088 Submission History API - Add both APIs and shell
command (`show submission`)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/
-----------------------------------------------------------
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Description
-------
commit 6367bd9781040a77a355a2728c0e365338eb497e
Author: Mengwei Ding <me...@cloudera.com>
Date: Tue Jun 18 15:43:25 2013 -0700
SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
:100644 100644 9c7b351... 0c5a596... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 100644 056fcc8... 39f19df... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 69edabb... 5042cb2... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
:100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
:000000 100644 0000000... 02b13bf... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
:100644 100644 b159757... 439196c... M client/src/main/resources/client-resource.properties
:100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 d42e34a... 6071b0e... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 3d29ab5... 0eaa539... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 21dd759... d321079... M core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 073d547... 9ebb510... M docs/src/site/sphinx/CommandLineClient.rst
:100644 100644 327896c... f91cd13... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
:100644 100644 45a0da4... a8fe905... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 c8ce3aa... de9303f... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 de9a24b... 489ea37... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
This addresses bug SQOOP-1088.
https://issues.apache.org/jira/browse/SQOOP-1088
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
client/src/main/resources/client-resource.properties b159757
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
docs/src/site/sphinx/CommandLineClient.rst 073d547
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
Diff: https://reviews.apache.org/r/11952/diff/
Testing
-------
Have done several tiny scale tests on my standalone virtual machine cluster.
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/#review22295
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On June 21, 2013, 11:06 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11952/
> -----------------------------------------------------------
>
> (Updated June 21, 2013, 11:06 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 7e11dd64165daae5297c843055041edb2803f5da
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Tue Jun 18 15:43:25 2013 -0700
>
> SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
>
> :100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 056fcc8... 06f8162... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
> :100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
> :100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
> :000000 100644 0000000... 666eb7a... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
> :100644 100644 1a6d896... 29144d1... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 100644 530ac92... 360a931... M client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
> :100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 6ee9aa1... 19a5bba... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 d42e34a... 135c2d2... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
> :100644 100644 21dd759... 666bfc1... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 073d547... a14898f... M docs/src/site/sphinx/CommandLineClient.rst
> :100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
> :100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 1c40fc1... 1f7a208... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-1088.
> https://issues.apache.org/jira/browse/SQOOP-1088
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
> client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
> client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
> client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 530ac92
> client/src/main/resources/client-resource.properties b159757
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
> docs/src/site/sphinx/CommandLineClient.rst 073d547
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 1c40fc1
>
> Diff: https://reviews.apache.org/r/11952/diff/
>
>
> Testing
> -------
>
> Have done several tiny scale tests on my standalone virtual machine cluster.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/
-----------------------------------------------------------
(Updated June 21, 2013, 11:06 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Changes
-------
add more unit test cases for TestSubmissionBean.
Description (updated)
-------
commit 7e11dd64165daae5297c843055041edb2803f5da
Author: Mengwei Ding <me...@cloudera.com>
Date: Tue Jun 18 15:43:25 2013 -0700
SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
:100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 100644 056fcc8... 06f8162... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
:100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
:100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
:000000 100644 0000000... 666eb7a... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
:100644 100644 1a6d896... 29144d1... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 100644 530ac92... 360a931... M client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
:100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 6ee9aa1... 19a5bba... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 d42e34a... 135c2d2... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 21dd759... 666bfc1... M core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 073d547... a14898f... M docs/src/site/sphinx/CommandLineClient.rst
:100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
:100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 1c40fc1... 1f7a208... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
This addresses bug SQOOP-1088.
https://issues.apache.org/jira/browse/SQOOP-1088
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 530ac92
client/src/main/resources/client-resource.properties b159757
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
docs/src/site/sphinx/CommandLineClient.rst 073d547
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 1c40fc1
Diff: https://reviews.apache.org/r/11952/diff/
Testing
-------
Have done several tiny scale tests on my standalone virtual machine cluster.
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 21, 2013, 6:31 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java, lines 48-49
> > <https://reviews.apache.org/r/11952/diff/3/?file=308715#file308715line48>
> >
> > The way other functions works is that --all and --jid are mutually exclusive. Here it seems that the "-all" parameter is used to get details, so maybe it would be worth to introduce a different parameter? (for example "--details"?)
yes, that's exactly what I mean.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/#review22263
-----------------------------------------------------------
On June 19, 2013, 6:59 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11952/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 6:59 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Tue Jun 18 15:43:25 2013 -0700
>
> SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
>
> :100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 056fcc8... 1365113... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
> :100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
> :100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
> :000000 100644 0000000... fc14929... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
> :100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
> :100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 d42e34a... 277dfcd... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
> :100644 100644 21dd759... 666bfc1... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 073d547... a1f8263... M docs/src/site/sphinx/CommandLineClient.rst
> :100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
> :100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 de9a24b... de4d723... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-1088.
> https://issues.apache.org/jira/browse/SQOOP-1088
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
> client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
> client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
> client/src/main/resources/client-resource.properties b159757
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
> docs/src/site/sphinx/CommandLineClient.rst 073d547
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
>
> Diff: https://reviews.apache.org/r/11952/diff/
>
>
> Testing
> -------
>
> Have done several tiny scale tests on my standalone virtual machine cluster.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 21, 2013, 6:31 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, line 486
> > <https://reviews.apache.org/r/11952/diff/3/?file=308719#file308719line486>
> >
> > Can we add here protective code that will verify that the job id is valid? Similarly as is in method findSubmissionLastForJob() for example.
yes, this is obvious. sorry for forgetting about this.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/#review22263
-----------------------------------------------------------
On June 19, 2013, 6:59 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11952/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 6:59 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Tue Jun 18 15:43:25 2013 -0700
>
> SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
>
> :100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 056fcc8... 1365113... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
> :100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
> :100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
> :000000 100644 0000000... fc14929... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
> :100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
> :100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 d42e34a... 277dfcd... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
> :100644 100644 21dd759... 666bfc1... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 073d547... a1f8263... M docs/src/site/sphinx/CommandLineClient.rst
> :100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
> :100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 de9a24b... de4d723... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-1088.
> https://issues.apache.org/jira/browse/SQOOP-1088
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
> client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
> client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
> client/src/main/resources/client-resource.properties b159757
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
> docs/src/site/sphinx/CommandLineClient.rst 073d547
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
>
> Diff: https://reviews.apache.org/r/11952/diff/
>
>
> Testing
> -------
>
> Have done several tiny scale tests on my standalone virtual machine cluster.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/#review22263
-----------------------------------------------------------
Hi Mengwei,
thank you very much for incorporating my suggestions! Would you mind rebasing your patch against current HEAD of sqoop2 branch? It do not seem to be applying cleanly anymore.
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
<https://reviews.apache.org/r/11952/#comment45733>
The way other functions works is that --all and --jid are mutually exclusive. Here it seems that the "-all" parameter is used to get details, so maybe it would be worth to introduce a different parameter? (for example "--details"?)
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
<https://reviews.apache.org/r/11952/#comment45734>
It seems that we have the same code also in SubmissionStatusFunction, so I would propose to put it into SubmissionDisplayer util class and share it.
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
<https://reviews.apache.org/r/11952/#comment45738>
Can we add new test into TestSubmissionBean that will transport multiple submissions to make sure that we won't regress from that in the future?
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/11952/#comment45737>
Can we add here protective code that will verify that the job id is valid? Similarly as is in method findSubmissionLastForJob() for example.
docs/src/site/sphinx/CommandLineClient.rst
<https://reviews.apache.org/r/11952/#comment45735>
The docs seems to be out of sync with the implemented functionality.
Jarcec
- Jarek Cecho
On June 19, 2013, 6:59 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11952/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 6:59 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Tue Jun 18 15:43:25 2013 -0700
>
> SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
>
> :100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 056fcc8... 1365113... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
> :100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
> :100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
> :000000 100644 0000000... fc14929... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
> :100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
> :100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 d42e34a... 277dfcd... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
> :100644 100644 21dd759... 666bfc1... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 073d547... a1f8263... M docs/src/site/sphinx/CommandLineClient.rst
> :100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
> :100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 de9a24b... de4d723... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-1088.
> https://issues.apache.org/jira/browse/SQOOP-1088
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
> client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
> client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
> client/src/main/resources/client-resource.properties b159757
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
> docs/src/site/sphinx/CommandLineClient.rst 073d547
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
>
> Diff: https://reviews.apache.org/r/11952/diff/
>
>
> Testing
> -------
>
> Have done several tiny scale tests on my standalone virtual machine cluster.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/
-----------------------------------------------------------
(Updated June 19, 2013, 6:59 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Changes
-------
Forget about previous change, because of some minor code format problem. Sorry.
Update from last change:
1. add "history" REST api for submission servlet, and make all its logic separated from "action"
2. add "--jid" option for `show submission` command
Description (updated)
-------
commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd
Author: Mengwei Ding <me...@cloudera.com>
Date: Tue Jun 18 15:43:25 2013 -0700
SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
:100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 100644 056fcc8... 1365113... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
:100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
:100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
:000000 100644 0000000... fc14929... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
:100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
:100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 d42e34a... 277dfcd... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 21dd759... 666bfc1... M core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 073d547... a1f8263... M docs/src/site/sphinx/CommandLineClient.rst
:100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
:100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 de9a24b... de4d723... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
This addresses bug SQOOP-1088.
https://issues.apache.org/jira/browse/SQOOP-1088
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
client/src/main/resources/client-resource.properties b159757
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
docs/src/site/sphinx/CommandLineClient.rst 073d547
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
Diff: https://reviews.apache.org/r/11952/diff/
Testing
-------
Have done several tiny scale tests on my standalone virtual machine cluster.
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/
-----------------------------------------------------------
(Updated June 19, 2013, 6:45 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Changes
-------
Update from last change:
1. add "history" REST api for submission servlet, and make all its logic separated from "action"
2. add "--jid" option for `show submission` command
Description (updated)
-------
commit 445bb5ec9c96f363f1c586d9ff534726c049a1cc
Author: Mengwei Ding <me...@cloudera.com>
Date: Tue Jun 18 15:43:25 2013 -0700
SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
:100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 100644 056fcc8... 4273683... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32d4ae1... f102c8f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
:100644 100644 69edabb... bafb30f... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
:100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
:000000 100644 0000000... fc14929... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
:100644 100644 bf26761... acba557... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
:100644 100644 b159757... 8a570a1... M client/src/main/resources/client-resource.properties
:100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 d42e34a... 277dfcd... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 3d29ab5... 538def5... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 21dd759... acb1fc9... M core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 073d547... a1f8263... M docs/src/site/sphinx/CommandLineClient.rst
:100644 100644 327896c... 4455f48... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
:100644 100644 45a0da4... 0ea7bac... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 c8ce3aa... 7a9ce50... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 de9a24b... de4d723... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
This addresses bug SQOOP-1088.
https://issues.apache.org/jira/browse/SQOOP-1088
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 32d4ae1
client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
client/src/main/resources/client-resource.properties b159757
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
docs/src/site/sphinx/CommandLineClient.rst 073d547
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
Diff: https://reviews.apache.org/r/11952/diff/
Testing
-------
Have done several tiny scale tests on my standalone virtual machine cluster.
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and
shell command (`show submission`)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/#review22094
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this ticket, greatly appreciated! I would strongly advise to use separate REST end point for retrieving submission history as is documented in:
https://github.com/apache/sqoop/blob/sqoop2/server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java#L30
The reason for that is that retrieving entire history might be quite expensive and long running task considering that Sqoop server can be hosting high number of historical submissions. Therefore it do make sense in my opinion to have separate very fast API for getting just the last submission that will be used in most cases and slower API for getting entire history when needed. I would suggest to create following new REST end points:
* /v1/submission/history/:jid For all historical submissions for job with id :jid
* /v1/submission/history/all For all historical submissions for all jobs
Jarcec
client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
<https://reviews.apache.org/r/11952/#comment45483>
I would suggest to make this client function similar to the others accepting either "--all" parameters for all submissions and "--jid" for submission from the particular job.
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
<https://reviews.apache.org/r/11952/#comment45484>
Nit: We need to provide good test coverage for SubmissionBean class.
- Jarek Cecho
On June 18, 2013, 11:54 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11952/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 11:54 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6367bd9781040a77a355a2728c0e365338eb497e
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Tue Jun 18 15:43:25 2013 -0700
>
> SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)
>
> :100644 100644 9c7b351... 0c5a596... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 056fcc8... 39f19df... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 69edabb... 5042cb2... M client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
> :100644 100644 e24a7e8... 4245717... M client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
> :000000 100644 0000000... 02b13bf... A client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
> :100644 100644 b159757... 439196c... M client/src/main/resources/client-resource.properties
> :100644 100644 1ef72eb... 91f2007... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 6ee9aa1... ba9e94c... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 d42e34a... 6071b0e... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 3d29ab5... 0eaa539... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
> :100644 100644 21dd759... d321079... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 073d547... 9ebb510... M docs/src/site/sphinx/CommandLineClient.rst
> :100644 100644 327896c... f91cd13... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
> :100644 100644 45a0da4... a8fe905... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 c8ce3aa... de9303f... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 de9a24b... 489ea37... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-1088.
> https://issues.apache.org/jira/browse/SQOOP-1088
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 69edabb
> client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java PRE-CREATION
> client/src/main/resources/client-resource.properties b159757
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 3d29ab5
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759
> docs/src/site/sphinx/CommandLineClient.rst 073d547
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 327896c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c8ce3aa
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
>
> Diff: https://reviews.apache.org/r/11952/diff/
>
>
> Testing
> -------
>
> Have done several tiny scale tests on my standalone virtual machine cluster.
>
>
> Thanks,
>
> Mengwei Ding
>
>