You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2018/03/01 13:46:03 UTC
[GitHub] flink pull request #5612: [FLINK-8810] Move end-to-end test scripts to end-t...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/5612
[FLINK-8810] Move end-to-end test scripts to end-to-end module
This also makes the tests executable by calling
$ flink-end-to-end-tests/run-pre-commit-tests.sh
R: @zentol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-8810-move-end-to-end-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5612
----
commit d4c1604f754e9befc86faddf8e00c05ea0db6f61
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-28T17:02:40Z
[FLINK-8810] Move end-to-end test scripts to end-to-end module
This also makes the tests executable by calling
$ flink-end-to-end-tests/run-pre-commit-tests.sh
----
---
[GitHub] flink pull request #5612: [FLINK-8810] Move end-to-end test scripts to end-t...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5612#discussion_r171571281
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -576,61 +576,9 @@ case $TEST in
printf "Running end-to-end tests\n"
printf "==============================================================================\n"
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running Wordcount end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target test-infra/end-to-end-test/test_batch_wordcount.sh
- EXIT_CODE=$?
- fi
-
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running Kafka end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target test-infra/end-to-end-test/test_streaming_kafka010.sh
- EXIT_CODE=$?
- fi
-
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running class loading end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target test-infra/end-to-end-test/test_streaming_classloader.sh
- EXIT_CODE=$?
- fi
-
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running Shaded Hadoop S3A end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target test-infra/end-to-end-test/test_shaded_hadoop_s3a.sh
- EXIT_CODE=$?
- fi
-
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running Shaded Presto S3 end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target test-infra/end-to-end-test/test_shaded_presto_s3.sh
- EXIT_CODE=$?
- fi
-
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running Hadoop-free Wordcount end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target CLUSTER_MODE=cluster test-infra/end-to-end-test/test_hadoop_free.sh
- EXIT_CODE=$?
- fi
-
- if [ $EXIT_CODE == 0 ]; then
- printf "\n==============================================================================\n"
- printf "Running Streaming Python Wordcount end-to-end test\n"
- printf "==============================================================================\n"
- FLINK_DIR=build-target test-infra/end-to-end-test/test_streaming_python_wordcount.sh
- EXIT_CODE=$?
- fi
+ FLINK_DIR=build-target flink-end-to-end-tests/run-pre-commit-tests.sh
--- End diff --
indentation is off as it uses spaces opposed to tabs
---
[GitHub] flink issue #5612: [FLINK-8810] Move end-to-end test scripts to end-to-end m...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5612
Thanks @zentol! I'm fixing the indentation and merging.
Btw, I'm using spaces in `run-pre-commit-tests.sh` because all other shell scripts in that folder also use spaces. Inconsistent, yes, but what can you do. I think at some point we have to normalise all those and enforce.
---
[GitHub] flink pull request #5612: [FLINK-8810] Move end-to-end test scripts to end-t...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5612#discussion_r171572132
--- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh ---
@@ -0,0 +1,98 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+END_TO_END_DIR="`dirname \"$0\"`" # relative
+END_TO_END_DIR="`( cd \"$END_TO_END_DIR\" && pwd )`" # absolutized and normalized
+if [ -z "$END_TO_END_DIR" ] ; then
+ # error; for some reason, the path is not accessible
+ # to the script (e.g. permissions re-evaled after suid)
--- End diff --
inconsistent indentation (tabs vs spaces)
---
[GitHub] flink pull request #5612: [FLINK-8810] Move end-to-end test scripts to end-t...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/5612
---