You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/11 23:32:01 UTC
Review Request 12473: Added a JSON::Protobuf for constructing JSON::Objects
from protobufs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12473/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This adds automatic Protobuf -> JSON conversion support.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp eb79e7b0a0cda6ef2086ab03aa2ba71e686cef38
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/12473/diff/
Testing
-------
Added a test.
Thanks,
Ben Mahler
Re: Review Request 12473: Added a JSON::Protobuf for constructing
JSON::Objects from protobufs.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12473/#review23044
-----------------------------------------------------------
Ship it!
Thanks Ben!
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
<https://reviews.apache.org/r/12473/#comment46862>
Maybe a std::cerr and abort?
- Benjamin Hindman
On July 11, 2013, 9:33 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12473/
> -----------------------------------------------------------
>
> (Updated July 11, 2013, 9:33 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-269
> https://issues.apache.org/jira/browse/MESOS-269
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds automatic Protobuf -> JSON conversion support.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp eb79e7b0a0cda6ef2086ab03aa2ba71e686cef38
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12473/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 12473: Added a JSON::Protobuf for constructing
JSON::Objects from protobufs.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12473/
-----------------------------------------------------------
(Updated July 11, 2013, 9:33 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Addresses part of MESOS-269.
Bugs: MESOS-269
https://issues.apache.org/jira/browse/MESOS-269
Repository: mesos
Description
-------
This adds automatic Protobuf -> JSON conversion support.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f51f0014a8c5d3
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp eb79e7b0a0cda6ef2086ab03aa2ba71e686cef38
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/12473/diff/
Testing
-------
Added a test.
Thanks,
Ben Mahler