You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "azexcy (via GitHub)" <gi...@apache.org> on 2023/02/20 11:48:01 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #24263: Fix multi unique key migration ignore inventory task when the first type is number
azexcy opened a new pull request, #24263:
URL: https://github.com/apache/shardingsphere/pull/24263
Changes proposed in this pull request:
- Fix multi unique key migration ignore inventory task when the first type is number
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #24263: Fix multi unique key migration ignore inventory task when the first type is number
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #24263:
URL: https://github.com/apache/shardingsphere/pull/24263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #24263: Fix multi unique key migration ignore inventory task when the first type is number
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #24263:
URL: https://github.com/apache/shardingsphere/pull/24263#discussion_r1111934075
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/InventoryDumper.java:
##########
@@ -140,12 +140,12 @@ private String buildInventoryDumpSQL() {
if (!dumperConfig.hasUniqueKey()) {
return sqlBuilder.buildNoUniqueKeyInventoryDumpSQL(schemaName, dumperConfig.getActualTableName());
}
+ PrimaryKeyPosition<?> position = (PrimaryKeyPosition<?>) dumperConfig.getPosition();
PipelineColumnMetaData firstColumn = dumperConfig.getUniqueKeyColumns().get(0);
- if (PipelineJdbcUtils.isIntegerColumn(firstColumn.getDataType())) {
+ if (PipelineJdbcUtils.isIntegerColumn(firstColumn.getDataType()) && null != position.getBeginValue() && null != position.getEndValue()) {
Review Comment:
`isIntegerColumn` could be the same logic as `isStringColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24263: Fix multi unique key migration ignore inventory task when the first type is number
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24263:
URL: https://github.com/apache/shardingsphere/pull/24263#issuecomment-1436928748
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24263?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24263](https://codecov.io/gh/apache/shardingsphere/pull/24263?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8234d73) into [master](https://codecov.io/gh/apache/shardingsphere/commit/411d65185bfec801de05c78698ea1e08461fa4ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (411d651) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 8234d73 differs from pull request most recent head 7cee1c3. Consider uploading reports for the commit 7cee1c3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24263 +/- ##
=========================================
Coverage 49.96% 49.96%
Complexity 1575 1575
=========================================
Files 3252 3252
Lines 53385 53385
Branches 9836 9837 +1
=========================================
+ Hits 26672 26674 +2
+ Misses 24349 24348 -1
+ Partials 2364 2363 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...api/ingest/position/PrimaryKeyPositionFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9pbmdlc3QvcG9zaXRpb24vUHJpbWFyeUtleVBvc2l0aW9uRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/pipeline/core/ingest/dumper/InventoryDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2luZ2VzdC9kdW1wZXIvSW52ZW50b3J5RHVtcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../packet/authentication/OpenGaussMacCalculator.java](https://codecov.io/gh/apache/shardingsphere/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYi9wcm90b2NvbC9vcGVuZ2F1c3MvcGFja2V0L2F1dGhlbnRpY2F0aW9uL09wZW5HYXVzc01hY0NhbGN1bGF0b3IuamF2YQ==) | `60.00% <0.00%> (+4.44%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #24263: Fix multi unique key migration ignore inventory task when the first type is number
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #24263:
URL: https://github.com/apache/shardingsphere/pull/24263#issuecomment-1437745869
Related to #24161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org