[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4316: HIVE-27337: Trim the starting and trailing white spaces in HMS for cr…

["dengzhhu653 (via GitHub)" <gi...@apache.org>]

dengzhhu653 commented on code in PR #4316:
URL: https://github.com/apache/hive/pull/4316#discussion_r1212469957


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -2276,6 +2277,9 @@ private void create_table_core(final RawStore ms, final CreateTableRequest req)
           + " already exists");
     }
 
+    tbl.setDbName(normalizeIdentifier(tbl.getDbName()));

Review Comment:
   The lineage info will feed into downstream project, so I'm a little nervous when the info changes.
   I think we can make changes here like:
   ```java
       Table tbl = new Table(req.getTable());
       tbl.setDbName(normalizeIdentifier(tbl.getDbName()));
       tbl.setTableName(normalizeIdentifier(tbl.getTableName()));



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org