You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sailaja (JIRA)" <ji...@apache.org> on 2016/05/18 10:31:13 UTC
[jira] [Commented] (DBCP-461) Prepared statements are not cached
with XA
[ https://issues.apache.org/jira/browse/DBCP-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288752#comment-15288752 ]
Sailaja commented on DBCP-461:
------------------------------
Yes. The insert should be parameterized. Even if it was parameterized there is a defect, the object returned for the prepared statement was
com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement instead of a proxy object if I use XA datasource. By using non XA datasource I am seeing a Proxy object being returned,
I tried parameterized statements and the result remained the same.
{code}
public static void main(String[] args) throws Exception
{
final TransactionManager transactionManager = TransactionManagerFactory
.getTransactionManager();
final PoolProperties poolProperties = new PoolProperties();
SQLServerXADataSource dataSource = new com.microsoft.sqlserver.jdbc.SQLServerXADataSource();
dataSource.setUser("sa");
dataSource.setPassword("$9Lserver");
dataSource.setURL("jdbc:sqlserver://sdwivedi63ks022:1433;sendStringParametersAsUnicode=false");
dataSource.setDatabaseName("himalaya");
poolProperties.setDataSource(dataSource);
final String jdbcInterceptors = "org.apache.tomcat.jdbc.pool.interceptor.StatementCache(prepared=true,callable=true)";
poolProperties.setJdbcInterceptors(jdbcInterceptors);
final org.apache.tomcat.jdbc.pool.DataSource pooledOracleDatasource = new org.apache.tomcat.jdbc.pool.XADataSource(
poolProperties);
final javax.sql.DataSource oracleDataSource = new org.apache.openejb.resource.jdbc.managed.xa.ManagedXADataSource(
pooledOracleDatasource, transactionManager,
TransactionProvider.getTransactionSynchronizationRegistry());
Connection connection = oracleDataSource.getConnection();
String preparedStatementString = "insert into MyTableNew (ID) values(?)";
for(int i=0; i<50; i++)
{
PreparedStatement preparedStatement = connection.prepareStatement(preparedStatementString);
preparedStatement.setInt(1, i);
System.out.println(preparedStatement.getClass().getName());
preparedStatement.execute();
preparedStatement.close();
}
connection.close();
}
{code}
> Prepared statements are not cached with XA
> ------------------------------------------
>
> Key: DBCP-461
> URL: https://issues.apache.org/jira/browse/DBCP-461
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.4
> Environment: TomEE Version : Apache Tomcat Version 7.0.63
> Reporter: Sailaja
>
> Prepared statements are not getting cached when I use XA datasource.
> Please find the below program :
> public static void main(String[] args) throws Exception
> {
> final TransactionManager transactionManager = TransactionManagerFactory
> .getTransactionManager();
> final PoolProperties poolProperties = new PoolProperties();
>
> SQLServerDataSource dataSource = new com.microsoft.sqlserver.jdbc.SQLServerDataSource();
> dataSource.setUser("sa");
> dataSource.setPassword("$9Lserver");
> dataSource.setURL("jdbc:sqlserver://sdwivedi63ks022:1433;sendStringParametersAsUnicode=false");
> dataSource.setDatabaseName("himalaya");
> poolProperties.setDataSource(dataSource);
>
> final String jdbcInterceptors = "org.apache.tomcat.jdbc.pool.interceptor.StatementCache(prepared=true,callable=true)";
> poolProperties.setJdbcInterceptors(jdbcInterceptors);
> final org.apache.tomcat.jdbc.pool.DataSource pooledOracleDatasource = new org.apache.tomcat.jdbc.pool.XADataSource(
> poolProperties);
> final javax.sql.DataSource oracleDataSource = new org.apache.openejb.resource.jdbc.managed.xa.ManagedXADataSource(
> pooledOracleDatasource, transactionManager,
> TransactionProvider.getTransactionSynchronizationRegistry());
> Connection connection = oracleDataSource.getConnection();
> for(int i=0; i<50; i++)
> {
> PreparedStatement preparedStatement = connection.prepareStatement("insert into MyTableNew values (" + i + ")");
> System.out.println(preparedStatement.getClass().getName());
> preparedStatement.execute();
> preparedStatement.close();
> }
> connection.close();
> }
> If I run the above program, the output I see is:
> com.sun.proxy.$Proxy11
> If I just change the above program to use XA datasource, i.e.
> Change the following line
> SQLServerDataSource dataSource = new com.microsoft.sqlserver.jdbc.SQLServerDataSource();
> To
> SQLServerXADataSource dataSource = new com.microsoft.sqlserver.jdbc.SQLServerXADataSource();
> The output is :
> com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)