[GitHub] [camel-k] astefanutti commented on issue #2397: Delete knative warning when Knative is not installed

[GitBox <gi...@apache.org>]

astefanutti commented on issue #2397:
URL: https://github.com/apache/camel-k/issues/2397#issuecomment-1012279224


   @claudio4j about my suggestion, the current implementation, that lists particular Knative resources in the namespace, barely check the presence of the Knative CRDs in the cluster, so it's not really scoped to the namespace. It could well be replaced with checking the discovery API if the Knative APIs are present, using https://github.com/apache/camel-k/blob/e9553940554ea533aaae2d0074681f37b434e7aa/pkg/util/kubernetes/discovery.go#L25, or even the `IsInstalled` function, whose result would be equivalent.
   
   For scoping the check to the namespace, I wonder if the `webhooks.knative.dev/exclude` annotation should be checked?
   
   Then, for the log message, I think it could be removed altogether, or moved to the _knative_ trait, in the `configure` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org