[GitHub] rhtyd commented on a change in pull request #2927: server: fix unwanted txn commit warning messages

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2927: server: fix unwanted txn commit warning messages
URL: https://github.com/apache/cloudstack/pull/2927#discussion_r227965994
 
 

 ##########
 File path: server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
 ##########
 @@ -886,60 +886,54 @@ public Long doInTransaction(TransactionStatus status) {
 
     @DB
     protected long recalculateAccountResourceCount(final long accountId, final ResourceType type) {
-        Long newCount = Transaction.execute(new TransactionCallback<Long>() {
-                @Override
-                public Long doInTransaction(TransactionStatus status) {
-                    Long newCount = null;
-                    lockAccountAndOwnerDomainRows(accountId, type);
 
 Review comment:
   Actually, it is not necessary as the values will be eventually consistent. I've however taken your review and added them back in a transaction. Please re-review the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services