You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by bi...@apache.org on 2012/06/27 13:42:25 UTC
svn commit: r1354439 -
/maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
Author: bimargulies
Date: Wed Jun 27 11:42:24 2012
New Revision: 1354439
URL: http://svn.apache.org/viewvc?rev=1354439&view=rev
Log:
MSHADE-123: 1.7 Causes failures in other plugins make "basedir" point to the build dir
o forgot to document the situation in the main checkin.
Modified:
maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
Modified: maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java?rev=1354439&r1=1354438&r2=1354439&view=diff
==============================================================================
--- maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java (original)
+++ maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java Wed Jun 27 11:42:24 2012
@@ -317,6 +317,9 @@ public class ShadeMojo
/**
* @parameter expression="${dependencyReducedPomLocation}" defaultValue="${basedir}/dependency-reduced-pom.xml"
+ * Note: setting a value for this parameter with a directory other than ${basedir} will change the value of ${basedir}
+ * for all executions that come after the shade execution. This is often not what you want. This is considered
+ * an open issue with this plugin.
*/
private File dependencyReducedPomLocation;