You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/04 02:33:04 UTC
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10749: [Feature][Metrics] Add resource download related metrics for workers
EricGao888 commented on PR #10749:
URL: https://github.com/apache/dolphinscheduler/pull/10749#issuecomment-1173273982
> # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10749?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> > Merging [#10749](https://codecov.io/gh/apache/dolphinscheduler/pull/10749?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ([16b7bb4](https://github.com/apache/dolphinscheduler/commit/16b7bb48fb5945b20142335e1176179004ec6b8e)) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/4ac33496e55dc1afb634f157455558a4fcaf443a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ([4ac3349](https://github.com/apache/dolphinscheduler/commit/4ac33496e55dc1afb634f157455558a4fcaf443a)) will **increase** coverage by `0.08%`.
> > The diff coverage is `88.63%`.
>
> ```diff
> @@ Coverage Diff @@
> ## dev #10749 +/- ##
> ============================================
> + Coverage 40.71% 40.79% +0.08%
> - Complexity 4820 4825 +5
> ============================================
> Files 900 900
> Lines 36143 36187 +44
> Branches 3982 3982
> ============================================
> + Hits 14717 14764 +47
> + Misses 19972 19969 -3
> Partials 1454 1454
> ```
>
> [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Coverage Δ
> [...pache/dolphinscheduler/common/utils/FileUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10749/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh) `51.42% <0.00%> (-1.52%)` ⬇️
> [...eduler/server/worker/runner/TaskExecuteThread.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10749/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza0V4ZWN1dGVUaHJlYWQuamF2YQ==) `21.32% <85.71%> (+3.49%)` ⬆️
> [...ler/server/worker/metrics/WorkerServerMetrics.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10749/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXRyaWNzL1dvcmtlclNlcnZlck1ldHJpY3MuamF2YQ==) `78.84% <94.28%> (+78.84%)` ⬆️
> [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10749?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
>
> > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10749?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4ac3349...16b7bb4](https://codecov.io/gh/apache/dolphinscheduler/pull/10749?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
I didn't add a line of UT, not sure why code coverage increased 🤣 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org