You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/04/09 12:22:10 UTC
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/575
HAWQ-647. fix compilation flag bug in debug mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-647
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #575
----
commit 10aa0943bdea9a2f6c6d9bedb17869c3e42c0e91
Author: xunzhang <xu...@gmail.com>
Date: 2016-04-09T10:20:58Z
HAWQ-647. fix compilation flag bug in debug mode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/575#issuecomment-207870809
Did you tried to use O0 build to break sendWithRetry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/575#issuecomment-207872669
@xunzhang Ok, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/575#issuecomment-207768809
cc @changleicn @jiny2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/575#issuecomment-207871693
@jiny2 Yes, I can break sendWithRetry in my local mac, Ruilong and Yao can also successfully break sendWithRetry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/575#issuecomment-207887724
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-647. fix compilation flag bug in...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/575#issuecomment-207898366
Already merged into master, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---