You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Shinichi Yamashita <ya...@nttdata.co.jp> on 2012/10/21 17:08:20 UTC
Review Request: SQOOP-387 : Use TRUNCATE for PostgresqlManager patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7689/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Sorry about my late reply.
This patch revised only PostgresqlManager not SqlManager.
I checked the processing about export using staging table in my PostgreSQL/Hadoop1.0 environment.
This addresses bug SQOOP-387.
https://issues.apache.org/jira/browse/SQOOP-387
Diffs
-----
Diff: https://reviews.apache.org/r/7689/diff/
Testing
-------
Thanks,
Shinichi Yamashita
Re: Review Request: SQOOP-387 : Use TRUNCATE for PostgresqlManager patch
Posted by Jarek Cecho <ja...@apache.org>.
> On Oct. 21, 2012, 4:18 p.m., Jarek Cecho wrote:
> > Hi Shinichi,
> > thank you very much for you patch. I appreciate your time and effort. Could you please upload the patch directly without using "Attach file functionality"? For example button "Update patch" in the left upper corner? Review board will apply your patch and very nicely show your changes, so that others (as myself) can review them.
> >
> > Jarcec
>
> Shinichi Yamashita wrote:
> Hi Jarcec,
>
> Thank you for your reply.
> I attach this patch at JIRA and status of JIRA changed to "Patch Available".
>
> Regards,
> Shinichi
Thank you sir, I appreciate that. Could you also upload your patch here to the review board? You should see a button "Update diff" in left upper corner.
Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7689/#review12632
-----------------------------------------------------------
On Oct. 21, 2012, 3:08 p.m., Shinichi Yamashita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7689/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2012, 3:08 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Sorry about my late reply.
>
> This patch revised only PostgresqlManager not SqlManager.
> I checked the processing about export using staging table in my PostgreSQL/Hadoop1.0 environment.
>
>
> This addresses bug SQOOP-387.
> https://issues.apache.org/jira/browse/SQOOP-387
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/7689/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shinichi Yamashita
>
>
Re: Review Request: SQOOP-387 : Use TRUNCATE for PostgresqlManager patch
Posted by Shinichi Yamashita <ya...@nttdata.co.jp>.
> On Oct. 21, 2012, 4:18 p.m., Jarek Cecho wrote:
> > Hi Shinichi,
> > thank you very much for you patch. I appreciate your time and effort. Could you please upload the patch directly without using "Attach file functionality"? For example button "Update patch" in the left upper corner? Review board will apply your patch and very nicely show your changes, so that others (as myself) can review them.
> >
> > Jarcec
Hi Jarcec,
Thank you for your reply.
I attach this patch at JIRA and status of JIRA changed to "Patch Available".
Regards,
Shinichi
- Shinichi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7689/#review12632
-----------------------------------------------------------
On Oct. 21, 2012, 3:08 p.m., Shinichi Yamashita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7689/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2012, 3:08 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Sorry about my late reply.
>
> This patch revised only PostgresqlManager not SqlManager.
> I checked the processing about export using staging table in my PostgreSQL/Hadoop1.0 environment.
>
>
> This addresses bug SQOOP-387.
> https://issues.apache.org/jira/browse/SQOOP-387
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/7689/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shinichi Yamashita
>
>
Re: Review Request: SQOOP-387 : Use TRUNCATE for PostgresqlManager patch
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7689/#review12632
-----------------------------------------------------------
Hi Shinichi,
thank you very much for you patch. I appreciate your time and effort. Could you please upload the patch directly without using "Attach file functionality"? For example button "Update patch" in the left upper corner? Review board will apply your patch and very nicely show your changes, so that others (as myself) can review them.
Jarcec
- Jarek Cecho
On Oct. 21, 2012, 3:08 p.m., Shinichi Yamashita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7689/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2012, 3:08 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Sorry about my late reply.
>
> This patch revised only PostgresqlManager not SqlManager.
> I checked the processing about export using staging table in my PostgreSQL/Hadoop1.0 environment.
>
>
> This addresses bug SQOOP-387.
> https://issues.apache.org/jira/browse/SQOOP-387
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/7689/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shinichi Yamashita
>
>