You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org> on 2024/03/04 14:19:33 UTC
[PR] AVRO-XXXX: [rust] allow deserializer to decode enum string [avro]
FlorentinDUBOIS opened a new pull request, #2785:
URL: https://github.com/apache/avro/pull/2785
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/main/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
This pull request allow to decode an avro enumeration from a previously encoded one.
Below, the example case to reproduce it.
```rust
#[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
pub struct StringEnum {
pub source: String,
}
#[test]
fn avro_xxxx_decode_enum() {
let schema_content = r#"
{
"name": "AccessLog",
"namespace": "com.clevercloud.accesslogs.common.avro",
"type": "record",
"fields": [
{
"name": "source",
"type": {
"type": "enum",
"name": "SourceType",
"items": "string",
"symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
}
}
]
}
"#;
let schema = crate::Schema::parse_str(schema_content).unwrap();
let data = StringEnum { source: "SOZU".to_string() };
// encode into avro
let value = crate::to_value(&data).unwrap();
let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
// decode from avro
let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
let decoded_data: StringEnum = crate::from_value(&value).unwrap();
// :arrow_double_up: throw => Failed to deserialize Avro value into value: Expected a String|Bytes|Fixed|Uuid|Union, but got Enum(0, "SOZU")
assert_eq!(decoded_data, data);
}
```
## Verifying this change
This change is already covered by existing tests on enums and a new tests `avro_xxxx_decode_enum`.
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2785:
URL: https://github.com/apache/avro/pull/2785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-XXXX: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976836877
Will do :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-XXXX: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on code in PR #2785:
URL: https://github.com/apache/avro/pull/2785#discussion_r1511333501
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,49 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_xxxx_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum { source: "SOZU".to_string() };
Review Comment:
It is done :heavy_check_mark:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-XXXX: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2785:
URL: https://github.com/apache/avro/pull/2785#discussion_r1511321832
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,49 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_xxxx_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum { source: "SOZU".to_string() };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
+
+ let decoded_data: StringEnum = crate::from_value(&value).unwrap();
+ // :arrow_double_up: throw => Failed to deserialize Avro value into value: Expected a String|Bytes|Fixed|Uuid|Union, but got Enum(0, "SOZU")
Review Comment:
What is the purpose of this comment here ?
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,49 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_xxxx_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum { source: "SOZU".to_string() };
Review Comment:
Let's add one more test case with a value that is not one of the enum symbols too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2785:
URL: https://github.com/apache/avro/pull/2785#discussion_r1511422833
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
Review Comment:
```suggestion
let schema = crate::Schema::parse_str(schema_content)?;
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
Review Comment:
```suggestion
let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value)?);
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
Review Comment:
```suggestion
let value = crate::to_value(&data)?;
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
+
+ let decoded_data: StringEnum = crate::from_value(&value).unwrap();
+
+ assert_eq!(decoded_data, data);
+ }
+
+ #[test]
+ fn avro_3955_encode_enum_data_with_wrong_content() {
Review Comment:
```suggestion
fn avro_3955_encode_enum_data_with_wrong_content() -> TestResult {
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
Review Comment:
```suggestion
let value = crate::from_avro_datum(&schema, &mut buf, None)?;
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
+
+ let decoded_data: StringEnum = crate::from_value(&value).unwrap();
Review Comment:
```suggestion
let decoded_data: StringEnum = crate::from_value(&value)?;
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
Review Comment:
```suggestion
fn avro_3955_decode_enum() -> TestResult {
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
+
+ let decoded_data: StringEnum = crate::from_value(&value).unwrap();
+
+ assert_eq!(decoded_data, data);
+ }
+
+ #[test]
+ fn avro_3955_encode_enum_data_with_wrong_content() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "WRONG_ITEM".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(data).unwrap();
Review Comment:
```suggestion
let value = crate::to_value(data)?;
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,85 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_3955_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum {
+ source: "SOZU".to_string(),
+ };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
+
+ let decoded_data: StringEnum = crate::from_value(&value).unwrap();
+
+ assert_eq!(decoded_data, data);
+ }
+
+ #[test]
+ fn avro_3955_encode_enum_data_with_wrong_content() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
Review Comment:
```suggestion
let schema = crate::Schema::parse_str(schema_content)?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-XXXX: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on code in PR #2785:
URL: https://github.com/apache/avro/pull/2785#discussion_r1511324944
##########
lang/rust/avro/src/de.rs:
##########
@@ -676,6 +676,49 @@ mod tests {
use super::*;
+ #[derive(PartialEq, Eq, Serialize, Deserialize, Debug)]
+ pub struct StringEnum {
+ pub source: String,
+ }
+
+ #[test]
+ fn avro_xxxx_decode_enum() {
+ let schema_content = r#"
+{
+ "name": "AccessLog",
+ "namespace": "com.clevercloud.accesslogs.common.avro",
+ "type": "record",
+ "fields": [
+ {
+ "name": "source",
+ "type": {
+ "type": "enum",
+ "name": "SourceType",
+ "items": "string",
+ "symbols": ["SOZU", "HAPROXY", "HAPROXY_TCP"]
+ }
+ }
+ ]
+}
+"#;
+
+ let schema = crate::Schema::parse_str(schema_content).unwrap();
+ let data = StringEnum { source: "SOZU".to_string() };
+
+ // encode into avro
+ let value = crate::to_value(&data).unwrap();
+
+ let mut buf = std::io::Cursor::new(crate::to_avro_datum(&schema, value).unwrap());
+
+ // decode from avro
+ let value = crate::from_avro_datum(&schema, &mut buf, None).unwrap();
+
+ let decoded_data: StringEnum = crate::from_value(&value).unwrap();
+ // :arrow_double_up: throw => Failed to deserialize Avro value into value: Expected a String|Bytes|Fixed|Uuid|Union, but got Enum(0, "SOZU")
Review Comment:
Just a forgotten comment from the issue example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1977255139
My pleasure :tophat:! Thank you very much! :heart:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976873045
@martin-g the issue is created and it is [AVRO-3955](https://issues.apache.org/jira/browse/AVRO-3955).
I have updated the pull request as well with the issue identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976967608
I have updated the commit with your changes.
I think you could not edit the pull request as you have not the right to do it on my fork, but should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "FlorentinDUBOIS (via GitHub)" <gi...@apache.org>.
FlorentinDUBOIS commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976971853
@martin-g can you click to trigger the ci?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1977241498
Thank you for the contribution, @FlorentinDUBOIS !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3955: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976959194
For some reason I cannot apply the suggestions from the Github UI ... I can do it later in the IDE!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-XXXX: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976830472
Please create the Jira issue and update the PR title with it and the test method names!
I can update the commit messages when squash+merging the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-XXXX: [Rust] allow deserializer to decode enum string [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2785:
URL: https://github.com/apache/avro/pull/2785#issuecomment-1976831245
You will need to `cargo fmt --all` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org