You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/22 15:02:13 UTC

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

BiteTheDDDDt opened a new pull request, #13581:
URL: https://github.com/apache/doris/pull/13581

   # Proposed changes
   
   
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1294450702

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 39.14 seconds
    load time: 598 seconds
    storage size: 17154821103 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028044531_clickbench_pr_35112.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1294884615

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.89 seconds
    load time: 568 seconds
    storage size: 17154644783 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028113112_clickbench_pr_35349.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1294513883

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 39.41 seconds
    load time: 571 seconds
    storage size: 17154821270 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028141904_clickbench_pr_35169.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on a diff in pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13581:
URL: https://github.com/apache/doris/pull/13581#discussion_r1017634553


##########
be/src/vec/exprs/vdirect_in_predicate.h:
##########
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/status.h"
+#include "vec/exprs/vexpr.h"
+
+namespace doris::vectorized {
+class VDirectInPredicate final : public VExpr {
+public:
+    VDirectInPredicate(const TExprNode& node)
+            : VExpr(node), _filter(nullptr), _expr_name("direct_in_predicate") {}
+    ~VDirectInPredicate() override = default;
+
+    Status execute(VExprContext* context, doris::vectorized::Block* block,
+                   int* result_column_id) override {
+        doris::vectorized::ColumnNumbers arguments(_children.size());
+        for (int i = 0; i < _children.size(); ++i) {
+            int column_id = -1;
+            RETURN_IF_ERROR(_children[i]->execute(context, block, &column_id));
+            arguments[i] = column_id;
+        }
+
+        size_t num_columns_without_result = block->columns();
+        auto res_data_column = ColumnVector<UInt8>::create(block->rows());
+        ColumnPtr argument_column =
+                block->get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+        size_t sz = argument_column->size();
+        res_data_column->resize(sz);
+
+        auto ptr = ((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
+        auto type = WhichDataType(remove_nullable(block->get_by_position(arguments[0]).type));
+        if (type.is_string_or_fixed_string()) {
+            for (size_t i = 0; i < sz; i++) {
+                auto ele = argument_column->get_data_at(i);
+                StringValue v(ele.data, ele.size);
+                ptr[i] = _filter->find(reinterpret_cast<const void*>(&v));
+            }
+        } else if (type.is_int_or_uint() || type.is_float()) {
+            if (argument_column->is_nullable()) {
+                auto column_nested = reinterpret_cast<const ColumnNullable*>(argument_column.get())
+                                             ->get_nested_column_ptr();
+                auto column_nullmap = reinterpret_cast<const ColumnNullable*>(argument_column.get())
+                                              ->get_null_map_column_ptr();
+                _filter->find_fixed_len(column_nested->get_raw_data().data,
+                                        (uint8*)column_nullmap->get_raw_data().data, sz, ptr);
+            } else {
+                _filter->find_fixed_len(argument_column->get_raw_data().data, nullptr, sz, ptr);
+            }
+        } else {
+            for (size_t i = 0; i < sz; i++) {
+                ptr[i] = _filter->find(
+                        reinterpret_cast<const void*>(argument_column->get_data_at(i).data));
+            }
+        }
+
+        if (_data_type->is_nullable()) {

Review Comment:
   this function only use by rf ? maybe do not need nullable column of result



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1293210806

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 39.15 seconds
    load time: 559 seconds
    storage size: 17154655346 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027085925_clickbench_pr_34676.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #13581:
URL: https://github.com/apache/doris/pull/13581#discussion_r1017520577


##########
be/src/olap/in_list_predicate.h:
##########
@@ -101,24 +102,78 @@ class InListPredicateBase : public ColumnPredicate {
             } else {
                 tmp = convert(condition);
             }
-            _values.insert(tmp);
-            if (tmp > _max_value) {
-                _max_value = tmp;
-            }
-            if (tmp < _min_value) {
-                _min_value = tmp;
+            _values->insert(tmp);
+            _update_min_max(tmp);
+        }
+    }
+
+    InListPredicateBase(uint32_t column_id, const std::shared_ptr<HybridSetBase>& hybrid_set,
+                        size_t char_length = 0)
+            : ColumnPredicate(column_id, false),
+              _min_value(type_limit<T>::max()),
+              _max_value(type_limit<T>::min()) {
+        using HybridSetType = std::conditional_t<is_string_type(Type), StringSet, HybridSet<Type>>;
+
+        CHECK(hybrid_set != nullptr);
+
+        if constexpr (is_string_type(Type) || Type == TYPE_DECIMALV2 || is_date_type(Type)) {
+            _values = new phmap::flat_hash_set<T>();
+            auto values = ((HybridSetType*)hybrid_set.get())->get_inner_set();
+
+            if constexpr (is_string_type(Type)) {
+                for (auto& value : *values) {
+                    StringValue sv = {value.data(), int(value.size())};
+                    if constexpr (Type == TYPE_CHAR) {
+                        _temp_datas.push_back("");
+                        _temp_datas.back().resize(std::max(char_length, value.size()));

Review Comment:
   https://cplusplus.com/reference/string/string/resize/ 
   `they are value-initialized characters.`  I think it means `char()`. 
   In other words, value-initialized characters is '\0'.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1291926220

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.65 seconds
    load time: 564 seconds
    storage size: 17154644810 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026200038_clickbench_pr_34322.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1294687485

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.4 seconds
    load time: 569 seconds
    storage size: 17154644748 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028162723_clickbench_pr_35231.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1293482318

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.67 seconds
    load time: 609 seconds
    storage size: 17154810701 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027205246_clickbench_pr_34824.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1291822022

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.64 seconds
    load time: 564 seconds
    storage size: 17154644814 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026182535_clickbench_pr_34289.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #13581:
URL: https://github.com/apache/doris/pull/13581#discussion_r1017529761


##########
be/src/exprs/in_predicate.cpp:
##########
@@ -35,13 +33,17 @@ InPredicate::InPredicate(const TExprNode& node)
           _null_in_set(false),
           _hybrid_set() {}
 
-InPredicate::~InPredicate() {}
+InPredicate::~InPredicate() {
+    if (_should_delete) {

Review Comment:
   InPredicate have another prepare function `InPredicate::prepare(RuntimeState* state, HybridSetBase* hset)`, when this prepare be used, we should do not delete `_hybrid_set`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1309896443

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] BiteTheDDDDt merged pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #13581:
URL: https://github.com/apache/doris/pull/13581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on a diff in pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13581:
URL: https://github.com/apache/doris/pull/13581#discussion_r1017510139


##########
be/src/olap/in_list_predicate.h:
##########
@@ -101,24 +102,78 @@ class InListPredicateBase : public ColumnPredicate {
             } else {
                 tmp = convert(condition);
             }
-            _values.insert(tmp);
-            if (tmp > _max_value) {
-                _max_value = tmp;
-            }
-            if (tmp < _min_value) {
-                _min_value = tmp;
+            _values->insert(tmp);
+            _update_min_max(tmp);
+        }
+    }
+
+    InListPredicateBase(uint32_t column_id, const std::shared_ptr<HybridSetBase>& hybrid_set,
+                        size_t char_length = 0)
+            : ColumnPredicate(column_id, false),
+              _min_value(type_limit<T>::max()),
+              _max_value(type_limit<T>::min()) {
+        using HybridSetType = std::conditional_t<is_string_type(Type), StringSet, HybridSet<Type>>;
+
+        CHECK(hybrid_set != nullptr);
+
+        if constexpr (is_string_type(Type) || Type == TYPE_DECIMALV2 || is_date_type(Type)) {
+            _values = new phmap::flat_hash_set<T>();
+            auto values = ((HybridSetType*)hybrid_set.get())->get_inner_set();
+
+            if constexpr (is_string_type(Type)) {
+                for (auto& value : *values) {
+                    StringValue sv = {value.data(), int(value.size())};
+                    if constexpr (Type == TYPE_CHAR) {
+                        _temp_datas.push_back("");
+                        _temp_datas.back().resize(std::max(char_length, value.size()));
+                        memcpy(_temp_datas.back().data(), value.data(), value.size());
+                        sv = {_temp_datas.back().data(), int(_temp_datas.back().size())};
+                    }
+                    _values->insert(sv);
+                }
+            } else if constexpr (Type == TYPE_DECIMALV2) {
+                for (auto& value : *values) {
+                    _values->insert({value.int_value(), value.frac_value()});
+                }
+            } else if constexpr (Type == TYPE_DATE) {
+                for (auto& value : *values) {
+                    _values->insert(value.to_olap_date());
+                }
+            } else if constexpr (Type == TYPE_DATETIME) {
+                for (auto& value : *values) {
+                    _values->insert(value.to_olap_datetime());
+                }
+            } else {
+                for (auto& value : *values) {

Review Comment:
   only ` is_string_type(Type) || Type == TYPE_DECIMALV2 || is_date_type(Type)` which case will be here ? maybe need DCHECK?



##########
be/src/olap/in_list_predicate.h:
##########
@@ -101,24 +102,78 @@ class InListPredicateBase : public ColumnPredicate {
             } else {
                 tmp = convert(condition);
             }
-            _values.insert(tmp);
-            if (tmp > _max_value) {
-                _max_value = tmp;
-            }
-            if (tmp < _min_value) {
-                _min_value = tmp;
+            _values->insert(tmp);
+            _update_min_max(tmp);
+        }
+    }
+
+    InListPredicateBase(uint32_t column_id, const std::shared_ptr<HybridSetBase>& hybrid_set,
+                        size_t char_length = 0)
+            : ColumnPredicate(column_id, false),
+              _min_value(type_limit<T>::max()),
+              _max_value(type_limit<T>::min()) {
+        using HybridSetType = std::conditional_t<is_string_type(Type), StringSet, HybridSet<Type>>;
+
+        CHECK(hybrid_set != nullptr);
+
+        if constexpr (is_string_type(Type) || Type == TYPE_DECIMALV2 || is_date_type(Type)) {
+            _values = new phmap::flat_hash_set<T>();
+            auto values = ((HybridSetType*)hybrid_set.get())->get_inner_set();
+
+            if constexpr (is_string_type(Type)) {
+                for (auto& value : *values) {
+                    StringValue sv = {value.data(), int(value.size())};
+                    if constexpr (Type == TYPE_CHAR) {
+                        _temp_datas.push_back("");
+                        _temp_datas.back().resize(std::max(char_length, value.size()));

Review Comment:
   resize can make sure the new len is filled by "\0" ?



##########
be/src/exprs/in_predicate.cpp:
##########
@@ -35,13 +33,17 @@ InPredicate::InPredicate(const TExprNode& node)
           _null_in_set(false),
           _hybrid_set() {}
 
-InPredicate::~InPredicate() {}
+InPredicate::~InPredicate() {
+    if (_should_delete) {

Review Comment:
   really we need `should_delete` ? use  _hybrid_set == nullptr or just use unique_ptr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1287827143

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 37.68 seconds
    load time: 564 seconds
    storage size: 17154887239 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221022232620_clickbench_pr_32791.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1294857463

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 39.09 seconds
    load time: 572 seconds
    storage size: 17154865254 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028190121_clickbench_pr_35328.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1291814477

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.67 seconds
    load time: 560 seconds
    storage size: 17154655391 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026101841_clickbench_pr_34284.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #13581: [Enhancement](runtime-filter) enlarge runtime filter in predicate threshold

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13581:
URL: https://github.com/apache/doris/pull/13581#issuecomment-1309896480

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org