[GitHub] [netbeans] matthiasblaesing commented on pull request #4619: Extend libs.flatlaf public packages

[GitBox <gi...@apache.org>]

matthiasblaesing commented on PR #4619:
URL: https://github.com/apache/netbeans/pull/4619#issuecomment-1248489388

   The problem with implementation versions is, that they create a hard dependency on a _single_ version of the corresponding package. What we could do is hardcode `OpenIDE-Module-Implementation-Version` to the value of the wrapped flatlaf library. That way the communication @DevCharly made about compatibility would be followed exactly, preventing linking against different versions.
   
   Friend module won't work here trivially as `libs.flatlaf`  already exports an API publicly and you can't do both from a single module. We could create a `org.netbeans.libs.flatlaf.full` module, that is part of the netbeans build and reexports the full flatlaf class set to a `org.netbeans.external.flatlaf.swingx` module as a friend API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists