You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jonathan Creasy <jo...@ghostlab.net> on 2013/07/29 21:19:15 UTC
Review Request 13025: Creating is mis-spelled in CreateFirewallRuleCmd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-3915
Repository: cloudstack-git
Description
-------
Fixing a typo in the firewall creation rule script.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283
Diff: https://reviews.apache.org/r/13025/diff/
Testing
-------
Ran it, seems to work.
Thanks,
Jonathan Creasy
Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/#review24206
-----------------------------------------------------------
Commit 650de7998d989c1bc4a6b5a0a98e3fad49bf2247 in branch refs/heads/master from Jonathan Creasy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=650de79 ]
Fixing typo of "createing" that should be "creating" https://issues.apache.org/jira/browse/CLOUDSTACK-3915
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 238815759664eb2a0e8c000389c976a8b1c5b269)
- ASF Subversion and Git Services
On July 29, 2013, 7:20 p.m., Jonathan Creasy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 7:20 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-3915
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing a typo in the firewall creation rule script.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283
>
> Diff: https://reviews.apache.org/r/13025/diff/
>
>
> Testing
> -------
>
> Ran it, seems to work.
>
>
> Thanks,
>
> Jonathan Creasy
>
>
Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/#review24160
-----------------------------------------------------------
Review 13025 PASSED the build test
The url of build cloudstack-master-with-patch #76 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/76/
- Jenkins Cloudstack.org
On July 29, 2013, 7:20 p.m., Jonathan Creasy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 7:20 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-3915
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing a typo in the firewall creation rule script.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283
>
> Diff: https://reviews.apache.org/r/13025/diff/
>
>
> Testing
> -------
>
> Ran it, seems to work.
>
>
> Thanks,
>
> Jonathan Creasy
>
>
Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/#review24208
-----------------------------------------------------------
Ship it!
- Prasanna Santhanam
On July 29, 2013, 7:20 p.m., Jonathan Creasy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 7:20 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-3915
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing a typo in the firewall creation rule script.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283
>
> Diff: https://reviews.apache.org/r/13025/diff/
>
>
> Testing
> -------
>
> Ran it, seems to work.
>
>
> Thanks,
>
> Jonathan Creasy
>
>
Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/#review24207
-----------------------------------------------------------
Commit 238815759664eb2a0e8c000389c976a8b1c5b269 in branch refs/heads/4.2 from Jonathan Creasy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2388157 ]
Fixing typo of "createing" that should be "creating" https://issues.apache.org/jira/browse/CLOUDSTACK-3915
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 29, 2013, 7:20 p.m., Jonathan Creasy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 7:20 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-3915
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing a typo in the firewall creation rule script.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283
>
> Diff: https://reviews.apache.org/r/13025/diff/
>
>
> Testing
> -------
>
> Ran it, seems to work.
>
>
> Thanks,
>
> Jonathan Creasy
>
>
Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by Jonathan Creasy <jo...@ghostlab.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/
-----------------------------------------------------------
(Updated July 29, 2013, 7:20 p.m.)
Review request for cloudstack.
Summary (updated)
-----------------
Bugfix CLOUDSTACK-3915: Creating is mis-spelled in CreateFirewallRuleCmd
Bugs: CLOUDSTACK-3915
Repository: cloudstack-git
Description
-------
Fixing a typo in the firewall creation rule script.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283
Diff: https://reviews.apache.org/r/13025/diff/
Testing
-------
Ran it, seems to work.
Thanks,
Jonathan Creasy
Re: Review Request 13025: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by Jonathan Creasy <jo...@contegix.com>.
Indeed. :)
----- Original Message -----
From: "Donal Lafferty" <do...@citrix.com>
To: "dev@cloudstack.apache.org" <de...@cloudstack.apache.org>, "Jonathan Creasy" <jo...@ghostlab.net>, "cloudstack" <cl...@incubator.apache.org>
Sent: Monday, July 29, 2013 2:34:59 PM
Subject: RE: Review Request 13025: Creating is mis-spelled in CreateFirewallRuleCmd
Ironically, there's no hyphen in 'misspelled' :)
> -----Original Message-----
> From: Jonathan Creasy [mailto:noreply@reviews.apache.org] On Behalf Of
> Jonathan Creasy
> Sent: 29 July 2013 8:19 PM
> To: cloudstack; Jonathan Creasy
> Subject: Review Request 13025: Creating is mis-spelled in
> CreateFirewallRuleCmd
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> -----------------------------------------------------------
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-3915
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing a typo in the firewall creation rule script.
>
>
> Diffs
> -----
>
>
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallR
> uleCmd.java ff8e283
>
> Diff: https://reviews.apache.org/r/13025/diff/
>
>
> Testing
> -------
>
> Ran it, seems to work.
>
>
> Thanks,
>
> Jonathan Creasy
RE: Review Request 13025: Creating is mis-spelled in
CreateFirewallRuleCmd
Posted by Donal Lafferty <do...@citrix.com>.
Ironically, there's no hyphen in 'misspelled' :)
> -----Original Message-----
> From: Jonathan Creasy [mailto:noreply@reviews.apache.org] On Behalf Of
> Jonathan Creasy
> Sent: 29 July 2013 8:19 PM
> To: cloudstack; Jonathan Creasy
> Subject: Review Request 13025: Creating is mis-spelled in
> CreateFirewallRuleCmd
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> -----------------------------------------------------------
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-3915
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing a typo in the firewall creation rule script.
>
>
> Diffs
> -----
>
>
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallR
> uleCmd.java ff8e283
>
> Diff: https://reviews.apache.org/r/13025/diff/
>
>
> Testing
> -------
>
> Ran it, seems to work.
>
>
> Thanks,
>
> Jonathan Creasy