You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <de...@db.apache.org> on 2006/02/10 22:47:20 UTC
[jira] Created: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Miscellaneous ResultSet methods added by JDBC 4
-----------------------------------------------
Key: DERBY-948
URL: http://issues.apache.org/jira/browse/DERBY-948
Project: Derby
Type: New Feature
Components: JDBC
Reporter: Rick Hillegas
Fix For: 10.2.0.0
As described in the JDBC 4 spec sections 16 and 3.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Knut Anders Hatlen updated DERBY-948:
-------------------------------------
Attachment: DERBY-948-v1.diff
DERBY-948-v1.stat
Uploaded a patch (DERBY-948-v1.diff) which implements
ResultSet.isClosed() and ResultSet.getHoldability() on embedded and
client. Also added some test cases to jdbc4/TestResultSetMethods.java.
In the client driver, I moved the methods from
(...).net.NetResultSet40 to (...).am.ResultSet since they didn't
contain any protocol specific or JDK 1.6 specific code.
I have run the jdbc4 suite on Solaris 10 x86 / Sun JVM 1.6.0_b72 and
derbyall on Solaris 10 x86 / Sun JVM 1.5.0 without errors.
Please review. Thanks.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-948) Miscellaneous ResultSet methods added by
JDBC 4
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Rick Hillegas closed DERBY-948:
-------------------------------
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat, DERBY-948-v3.diff, DERBY-948-v3.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Knut Anders Hatlen updated DERBY-948:
-------------------------------------
Other Info: [Patch available]
Current patch is DERBY-948-v3.diff. Please review. Thanks.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat, DERBY-948-v3.diff, DERBY-948-v3.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Knut Anders Hatlen resolved DERBY-948:
--------------------------------------
Resolution: Fixed
Thanks for reviewing, Rick! Committed revision 382710.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat, DERBY-948-v3.diff, DERBY-948-v3.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=comments#action_12368319 ]
Knut Anders Hatlen commented on DERBY-948:
------------------------------------------
Just realized there might be one issue with my implementation of
ResultSet.getHoldability() in the embedded driver. To find the
holdability, one has to call
ResultSet.getStatement().getResultSetHoldability(). However,
getStatement() might return null leading to a NullPointerException.
It seems like the only way to get a ResultSet which returns null for
getStatement() is through EmbedConnectionContext.getResultSet(). What
is the holdability of the result sets returned by this method? And can
those result sets be exposed to an application, or are they just used
internally?
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Knut Anders Hatlen updated DERBY-948:
-------------------------------------
Attachment: DERBY-948-v2.diff
DERBY-948-v2.stat
Attached a new patch (DERBY-948-v2.diff). Modified one test case so that exceptions aren't swallowed.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Rick Hillegas updated DERBY-948:
--------------------------------
Description:
As described in the JDBC 4 spec sections 16 and 3.1.
This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
was:As described in the JDBC 4 spec sections 16 and 3.1.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Fix For: 10.2.0.0
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Knut Anders Hatlen updated DERBY-948:
-------------------------------------
Attachment: DERBY-948-v3.diff
DERBY-948-v3.stat
I investigated the possibility for null pointer exceptions
further. The only result sets that return null in getStatement() are
those created by getNewRowSet() and getOldRowSet() in
InternalTriggerExecutionContext. Those result sets are not exposed to
JDBC applications, so applications can't call getHoldability() on them
anyway. However, I updated the patch with a comment about the null
case, and made getHoldability() return CLOSE_CURSORS_AT_COMMIT instead
of throwing NullPointerException.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat, DERBY-948-v3.diff, DERBY-948-v3.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=all ]
Knut Anders Hatlen reassigned DERBY-948:
----------------------------------------
Assign To: Knut Anders Hatlen
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-948) Miscellaneous ResultSet methods added
by JDBC 4
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-948?page=comments#action_12368625 ]
Rick Hillegas commented on DERBY-948:
-------------------------------------
Hi Knut Anders,
Solid code, good comments, useful tests. Derbyall runs cleanly for me modulo the wisconsin cruft. The jdbc4 tests run cleanly modulo the timestamp formatting cruft. I say commit away.
> Miscellaneous ResultSet methods added by JDBC 4
> -----------------------------------------------
>
> Key: DERBY-948
> URL: http://issues.apache.org/jira/browse/DERBY-948
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: DERBY-948-v1.diff, DERBY-948-v1.stat, DERBY-948-v2.diff, DERBY-948-v2.stat, DERBY-948-v3.diff, DERBY-948-v3.stat
>
> As described in the JDBC 4 spec sections 16 and 3.1.
> This provides support for new ResultSet methods added by JDBC4 and not addressed by other JIRAs: getHoldability() and isClosed().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira