You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "chrjohn (via GitHub)" <gi...@apache.org> on 2025/10/27 18:06:42 UTC
[PR] added Maven Wrapper [mina-sshd]
chrjohn opened a new pull request, #849:
URL: https://github.com/apache/mina-sshd/pull/849
... to eliminate the need to install a specific Maven version locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf merged PR #849:
URL: https://github.com/apache/mina-sshd/pull/849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3492900909
Done :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] added Maven Wrapper [mina-sshd]
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on code in PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#discussion_r2469970729
##########
assembly/src/main/descriptors/unix-src.xml:
##########
Review Comment:
I'm not sure I got the logic right on `unix-src.xml` and `windows-src.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] added Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on code in PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#discussion_r2486036974
##########
assembly/src/main/descriptors/unix-src.xml:
##########
Review Comment:
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3492876869
That would be great, thanks. :)
Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3492865862
Shall I do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] added Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3479896951
Works as intended on Windows in cmd.exe and in git bash; works well on Mac. Scripts have the correct line endings in the source archives produced in the assembly project.
This look good. Please squash the commits into one, and give it a good commit message. Then this is ready to go in.
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3490596180
@tomaswolf could you please check if it is OK. Probably my last merge messed things up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3492694284
Hmm, force pushing does not work, says working directory is clean. Will check again tomorrow...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] added Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3452995879
What about line endings? Force LF for mvnw and CR-LF for mvnw.cmd on checkout via .gitattributes? Also we should ensure in the assembly project that these two files get the right line endings when archived.
What line endings do the properties need? Will they work if it's LF-only on Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] added Maven Wrapper [mina-sshd]
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3455267212
I'll look into the attributes stuff.
As for the properties: I cannot test this on Windows but I have a similar setup on the QuickFIX/J project where the wrapper works fine in github actions on Linux and Windows. https://github.com/quickfix-j/quickfixj/blob/master/.github/workflows/maven.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3490697846
> Probably my last merge messed things up?
Yes, it did :-) Just check-out your squash commit e82a9d3 and force-push it onto your chrjohn:mvn-wrapper branch (i.e., the mvn-wrapper branch in your fork). That should fix it: we should end up with this PR being updated and having only the single commit e82a9d3.
The squash itself worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Add Maven Wrapper [mina-sshd]
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on PR #849:
URL: https://github.com/apache/mina-sshd/pull/849#issuecomment-3493010644
> Done :-)
Thank you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org