[GitHub] [nutch] sebastian-nagel commented on a change in pull request #689: NUTCH-2881 bug in 'nutch' symlink in docker container

[GitBox <gi...@apache.org>]

sebastian-nagel commented on a change in pull request #689:
URL: https://github.com/apache/nutch/pull/689#discussion_r658633007



##########
File path: docker/Dockerfile
##########
@@ -32,4 +32,4 @@ RUN git clone https://github.com/apache/nutch.git nutch_source && \
      rm -rf /root/.ivy2/
 
 # Convenience symlink to Nutch runtime local

Review comment:
       The comment should reflect that the symlink now points to the script bin/nutch.
   
   Just two ideas:
   - defining the environment variable NUTCH_HOME could be useful:
     ```
     env NUTCH_HOME=`/root/nutch_source/runtime/local`
     ```
   - why not put symlinks to bin/nutch (and bin/crawl) into /usr/local/bin to make them available from everywhere?
     ```
     ln -sf $NUTCH_HOME/bin/nutch /usr/local/bin/
     ln -sf $NUTCH_HOME/bin/crawl /usr/local/bin/
    ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org