You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by zhilhuan <gi...@git.apache.org> on 2017/08/23 06:34:06 UTC
[GitHub] incubator-trafficcontrol pull request #855: [TC-547] Fix regression issues c...
GitHub user zhilhuan opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/855
[TC-547] Fix regression issues caused by TC-187
Fix regression issues caused by TC-187:
1. revert: replace xml_id with ds_<ds-id> as riak key for ssl certificate
2. revert: decode base64 for ssl csr, crt, key in restful api
Add missing code for update ssl keystore when hostname changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhilhuan/incubator-trafficcontrol TC-547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/855.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #855
----
commit 8dd685f4ee99c17f212839bc7d61e9b7553d6e67
Author: Zhilin Huang <zh...@cisco.com>
Date: 2017-08-23T03:03:03Z
Fix regression issues caused by TC-187:
1. revert: replace xml_id with ds_<ds-id> as riak key for ssl certificate
2. revert: decode base64 for ssl csr, crt, key in restful api
Add missing code for update ssl keystore when hostname changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by DylanVolz <gi...@git.apache.org>.
Github user DylanVolz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
@zhilhuan Yes that was a build server issue that should be resolved now.
This PR looks good; it reverts the breaking changes introduced by the change from xmlId to id in the keysto store ssl keys in riak.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by zhilhuan <gi...@git.apache.org>.
Github user zhilhuan commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
fatal: ambiguous argument 'TC-547': unknown revision or path not in the working tree.
This is a issue in build server, not my code, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by zhilhuan <gi...@git.apache.org>.
Github user zhilhuan commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
@rawlinp Thanks for your comments! Yes, that's need aother discussion, because the certs may be pasted by operator instead of generated by ops.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/84/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #855: [TC-547] Fix regression issues c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by rawlinp <gi...@git.apache.org>.
Github user rawlinp commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Looks good to me. Thanks for fixing this!
Note that we'll have to figure out if we want to regenerate the actual certs too (rather than just the hostname in the riak record), but we'll tackle that in a new PR once we've discussed what needs to be done about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by zhilhuan <gi...@git.apache.org>.
Github user zhilhuan commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
@rawlinp This PR reverted the regression issues introduced by TC-187. And also resolved your comments in PR#360. Please help to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/124/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---