You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2014/05/01 08:37:09 UTC

Re: [ACS44]cherry pick CLOUDSTACK-6517

On Wed, Apr 30, 2014 at 9:00 PM, Prachi Damle <Pr...@citrix.com> wrote:
> e14c2ec7241ec2333ea3ac3d56a0e938fe1bf131


Prachi, your commit contains dos line endings:
-        IAMPolicyPermissionVO permit =
_policyPermissionDao.findByPolicyAndEntity(iamPolicyId, entityType,
scope, scopeId, action, perm);
+        IAMPolicyPermissionVO permit =
_policyPermissionDao.findByPolicyAndEntity(iamPolicyId, entityType,
scope,^M
+                scopeId, action, perm, accessType);^M

Since I only saw them in java files I will let it pass but please
adjust your work environment to prevent the line endings to enter the
system. When they end up in configuration files or scripts things
might break inexplicably.

-- 
Daan

RE: [ACS44]cherry pick CLOUDSTACK-6517

Posted by Prachi Damle <Pr...@citrix.com>.

Yes, I will check my work environment again for this.

Prachi
-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com] 
Sent: Wednesday, April 30, 2014 11:37 PM
To: dev
Subject: Re: [ACS44]cherry pick CLOUDSTACK-6517

On Wed, Apr 30, 2014 at 9:00 PM, Prachi Damle <Pr...@citrix.com> wrote:
> e14c2ec7241ec2333ea3ac3d56a0e938fe1bf131


Prachi, your commit contains dos line endings:
-        IAMPolicyPermissionVO permit =
_policyPermissionDao.findByPolicyAndEntity(iamPolicyId, entityType, scope, scopeId, action, perm);
+        IAMPolicyPermissionVO permit =
_policyPermissionDao.findByPolicyAndEntity(iamPolicyId, entityType, scope,^M
+                scopeId, action, perm, accessType);^M

Since I only saw them in java files I will let it pass but please adjust your work environment to prevent the line endings to enter the system. When they end up in configuration files or scripts things might break inexplicably.

--
Daan