You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 14:32:20 UTC

[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2287: Add BatchPartitioner (#2285)

tustvold opened a new pull request, #2287:
URL: https://github.com/apache/arrow-datafusion/pull/2287

   # Which issue does this PR close?
   
   Closes #2285
   
    # Rationale for this change
   
   Extracts common logic so it can be used by RepartitionExec, Ballista and #2226 
   
   # What changes are included in this PR?
   
   Adds a [`BatchPartitioner`] that contains the logic for partitioning batches
   
   # Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan merged pull request #2287: Add BatchPartitioner (#2285)

Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #2287:
URL: https://github.com/apache/arrow-datafusion/pull/2287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #2287: Add BatchPartitioner (#2285)

Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #2287:
URL: https://github.com/apache/arrow-datafusion/pull/2287#discussion_r854287956


##########
datafusion/core/src/physical_plan/repartition.rs:
##########
@@ -87,7 +87,7 @@ impl BatchPartitioner {
     /// Create a new [`BatchPartitioner`] with the provided [`Partitioning`]
     ///
     /// The time spent repartitioning will be recorded to `timer`
-    pub fn new(partitioning: Partitioning, timer: metrics::Time) -> Self {
+    pub fn new(partitioning: Partitioning, timer: metrics::Time) -> Result<Self> {

Review Comment:
   Shouldn´t this be `try_new` now by convention?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #2287: Add BatchPartitioner (#2285)

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #2287:
URL: https://github.com/apache/arrow-datafusion/pull/2287#issuecomment-1104289335

   Thanks @tustvold :tada: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org