You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2021/04/19 07:08:27 UTC
[GitHub] [jmeter] orimarko opened a new pull request #663: Bug 61805 - Allow simple HTTP request
orimarko opened a new pull request #663:
URL: https://github.com/apache/jmeter/pull/663
## Description
Add simple HTTP request template
Creates an HTTP Request with Header Manager and View Results Tree
## Motivation and Context
Simplify creating a simple HTTP request
## How Has This Been Tested?
Create simple HTTP request with and without defaults on windows GUI
## Screenshots (if appropriate):
NA
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- New feature (non-breaking change which adds functionality)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [X ] My code follows the [code style][style-guide] of this project.
- [X ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] orimarko commented on a change in pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
orimarko commented on a change in pull request #663:
URL: https://github.com/apache/jmeter/pull/663#discussion_r672214534
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
@FSchumacher I don't see an issue with spaves
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
@FSchumacher I don't see an issue with spaves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #663:
URL: https://github.com/apache/jmeter/pull/663#issuecomment-895185545
Thanks for the PR. I fixed the last spacing issues and squashed the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] orimarko closed pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
orimarko closed pull request #663:
URL: https://github.com/apache/jmeter/pull/663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] asfgit closed pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #663:
URL: https://github.com/apache/jmeter/pull/663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on a change in pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
FSchumacher commented on a change in pull request #663:
URL: https://github.com/apache/jmeter/pull/663#discussion_r615952741
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
+ <li>Body data</li>
+ </ul>
+ </p>
+ ]]></description>
+ <parameters>
+ <parameter defaultValue="https://jmeter.apache.org/" key="url"/>
Review comment:
Maybe we should take another domain than our own, so no DOS will result ;) In the documentation we use something ending on `example.invalid`. That way no one innocent will be harmed by the default settings.
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
Nobody will see it, but could you try to keep the spacepolice happy?
##########
File path: src/core/src/main/java/org/apache/jmeter/testelement/TestElement.java
##########
@@ -315,9 +315,9 @@
String getName();
/**
- * Returns name of this element.
+ * Associates a name with this element.
Review comment:
This seems to be left over from some other PR?
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
+ <li>Body data</li>
+ </ul>
+ </p>
+ ]]></description>
+ <parameters>
+ <parameter defaultValue="https://jmeter.apache.org/" key="url"/>
+ <parameter defaultValue="application/json" key="contentType"/>
+ <parameter defaultValue="POST" key="method"/>
+ <parameter defaultValue="" key="body"/>
Review comment:
We need space ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] orimarko commented on a change in pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
orimarko commented on a change in pull request #663:
URL: https://github.com/apache/jmeter/pull/663#discussion_r672214534
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
@FSchumacher I don't see an issue with spaves
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
@FSchumacher I don't see an issue with spaves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] orimarko commented on a change in pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
orimarko commented on a change in pull request #663:
URL: https://github.com/apache/jmeter/pull/663#discussion_r672214534
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
@FSchumacher I don't see an issue with spaves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] orimarko commented on a change in pull request #663: Bug 61805 - Allow simple HTTP request
Posted by GitBox <gi...@apache.org>.
orimarko commented on a change in pull request #663:
URL: https://github.com/apache/jmeter/pull/663#discussion_r672214534
##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
</ul>
]]></description>
</template>
+ <template isTestPlan="true">
+ <name>Simple HTTP request</name>
+ <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+ <description><![CDATA[
+ <h1>Template for simple HTTP request</h1>
+ <h2>JMeter Configuration</h2>
+ <p>Configure your HTTP request, set:
+ <ul>
+ <li>Full URL</li>
+ <li>Content Type</li>
+ <li>HTTP method</li>
Review comment:
@FSchumacher I don't see an issue with spaves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org