[GitHub] [maven] gnodet commented on a change in pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…

[GitBox <gi...@apache.org>]

gnodet commented on a change in pull request #475:
URL: https://github.com/apache/maven/pull/475#discussion_r646180776



##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -347,84 +351,62 @@ public void addTestCompileSourceRoot( String path )
         return testCompileSourceRoots;
     }
 
+    @Deprecated

Review comment:
       I'm willing to provide more doc once there's a consensus.
   Honestly, I'm not even sure we need such an API, unless there's a clear path for the deprecation and for moving to a more immutable `MavenProject`.   What are the deprecation rules ? Will 4.0 remove things deprecated in 3.x ? If they stay forever, there's really no point in deprecating and trying to find slightly better APIs...  I'm just asking here, but 3.0 is very old I think there are quite a few things that are deprecated since early 3.x versions, which looks like 10 years or so.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org