You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/11/05 22:18:58 UTC
[GitHub] kaxil closed pull request #4125: [AIRFLOW-2715] Pick up the region
setting while launching Dataflow templates
kaxil closed pull request #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates
URL: https://github.com/apache/incubator-airflow/pull/4125
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/contrib/hooks/gcp_dataflow_hook.py b/airflow/contrib/hooks/gcp_dataflow_hook.py
index 4fdb07c74d..f6d7768cf7 100644
--- a/airflow/contrib/hooks/gcp_dataflow_hook.py
+++ b/airflow/contrib/hooks/gcp_dataflow_hook.py
@@ -278,8 +278,9 @@ def _start_template_dataflow(self, name, variables, parameters,
"parameters": parameters,
"environment": environment}
service = self.get_conn()
- request = service.projects().templates().launch(
+ request = service.projects().locations().templates().launch(
projectId=variables['project'],
+ location=variables['region'],
gcsPath=dataflow_template,
body=body
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services