[GitHub] [kafka] C0urante commented on a diff in pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on code in PR #12366:
URL: https://github.com/apache/kafka/pull/12366#discussion_r1101982892


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -188,11 +196,52 @@ public ConfigDef config() {
         return MirrorSourceConfig.CONNECTOR_CONFIG_DEF;
     }
 
+    @Override
+    public org.apache.kafka.common.config.Config validate(Map<String, String> props) {
+        List<ConfigValue> configValues = MirrorSourceConfig.CONNECTOR_CONFIG_DEF.validate(props);

Review Comment:
   Fine by me, done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org