You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "torwig (via GitHub)" <gi...@apache.org> on 2023/04/08 14:12:18 UTC

[GitHub] [incubator-kvrocks] torwig opened a new pull request, #1375: Add MEMORY USAGE command as an alias to existing DISK USAGE command

torwig opened a new pull request, #1375:
URL: https://github.com/apache/incubator-kvrocks/pull/1375

   Since Redis has the `MEMORY` command, tools like `RedisInsight` use it to show information to the user.
   Currently, `RedisInsight` can't show memory usage by keys because `Kvrocks` doesn't support the `MEMORY USAGE` command.
   Solution: make the `MEMORY USAGE` command an alias to the `DISK USAGE` command. 
   Currently, the `MEMORY USAGE` command doesn't support the optional `SAMPLES` option.
   The integration test basically checks that `Kvrocks` support the new command and the response is an integer value conforming to the Redis spec.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk merged pull request #1375: Add MEMORY USAGE command as an alias to existing DISK USAGE command

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #1375:
URL: https://github.com/apache/incubator-kvrocks/pull/1375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #1375: Add MEMORY USAGE command as an alias to existing DISK USAGE command

Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #1375:
URL: https://github.com/apache/incubator-kvrocks/pull/1375#issuecomment-1500950716

   Good, thanks! Now I use a redisInsight tool im work and we have two separated service, redis and kvroks, and this features very good to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1375: Add MEMORY USAGE command as an alias to existing DISK USAGE command

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1375:
URL: https://github.com/apache/incubator-kvrocks/pull/1375#issuecomment-1501139572

   Thanks all, merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org