[jira] [Commented] (DRILL-7213) drill-format-mapr.jar contains stale git.properties file

["Volodymyr Vysotskyi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825949#comment-16825949 ] 

Volodymyr Vysotskyi commented on DRILL-7213:
--------------------------------------------

This issue happens because of the changes made in DRILL-6751. In the scope of this Jira was changed the way how Jars are included in the assembly. For now, {{moduleSets/moduleSet}} is used, but such an approach has some issues. The first one is that it does not handle dependencies added/excluded in the module, therefore even when {{drill-format-mapr}} dependency is added only for the mapr profile, it will be included for default profile also, if it was already built before, so it is the reason for the problem, described in this Jira.

The second issue is that it works correctly when the goal is run for the parent module, i.e. when the project was built, and {{mvn clean install -pl distribution}} is executed, module jars wouldn't be included in the assembly.

The solution is to replace back {{moduleSets}} with the {{dependencySets}}.

> drill-format-mapr.jar contains stale git.properties file
> --------------------------------------------------------
>
>                 Key: DRILL-7213
>                 URL: https://issues.apache.org/jira/browse/DRILL-7213
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.16.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>            Priority: Major
>             Fix For: 1.16.0
>
>
> For some reason only drill-format-mapr jar in the release candidate tarball contains a stale git.properties file which is available during the prepare phase. Other format plugin jar seems fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)