[GitHub] commons-imaging pull request #34: IMAGING-188

[kinow <gi...@git.apache.org>]

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/34#discussion_r204226800
  
    --- Diff: pom.xml ---
    @@ -209,6 +209,12 @@
           <version>2.6</version>
           <scope>test</scope>
         </dependency>
    +    <!-- necessary modification of ImageIO for support of JPEG 2000 -->
    +    <dependency>
    +      <groupId>com.github.jai-imageio</groupId>
    +      <artifactId>jai-imageio-jpeg2000</artifactId>
    +      <version>1.3.0</version>
    +    </dependency>
    --- End diff --
    
    Adding a dependency to `jai-imageio-jpeg2000` brings `jai-imageio-core` too I believe. ImageIO and Commons Imaging share a lot of features. But, IMO, adding a dependency from one to another, would be like adding TestNG as a dependency in JUnit to get the TestNG groups feature.
    
    A better approach, IMO, would be to build up the required code for JPEG2000 either within Commons Imaging or as a module. And then implement the rest of the code as you have it here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org