[jira] Commented: (XERCESC-1467) Socket 's' in the 'BinHTTPURLInputStream' constructor is never closed when an exception occurs.

["Ronald Lamprecht (JIRA)" <xe...@xml.apache.org>]

    [ http://issues.apache.org/jira/browse/XERCESC-1467?page=comments#action_12330677 ] 

Ronald Lamprecht commented on XERCESC-1467:
-------------------------------------------

The fix introduces in src\xercesc\util\NetAccessors\WinSock\BinHTTPURLInputStream.cpp line 52 a direct call to function "closesocket" of the wsock32 library. All other access to wsock32 is handled dynamically.

As a result the samples will not link without the additon of "-l wsock32"  or  an "AC_CHECK_LIB" in configure.ac.

The solution will be of course a dynamic call of "closesocket" in "SocketJanitor::reset()".

The problem was introduced in r231012 on the trunk and is still valid in r290103.


> Socket 's' in the 'BinHTTPURLInputStream' constructor is never closed when an exception occurs.
> -----------------------------------------------------------------------------------------------
>
>          Key: XERCESC-1467
>          URL: http://issues.apache.org/jira/browse/XERCESC-1467
>      Project: Xerces-C++
>         Type: Bug
>   Components: Utilities
>     Versions: 2.5.0
>     Reporter: Rogério Corrêa

>
> When an exception occurs in the constructor of the class BinHTTPURLInputStream, the socket opened in the call to 'socket' is never closed.
> I´m calling closesocket before every throw, but considering a socket object maybe better.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org