You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/09/07 13:37:11 UTC
[Bug 58339] New: [PATCH] Make OFFSET() accept missing parameters
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
Bug ID: 58339
Summary: [PATCH] Make OFFSET() accept missing parameters
Product: POI
Version: 3.13-dev
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: SS Common
Assignee: dev@poi.apache.org
Reporter: patrick.zimmermann@haltec.de
Created attachment 33072
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33072&action=edit
offset_missing_arg.patch
This patch makes the OFFSET function also work with one or both of the last two
parameters missing. Excel 2013 also behaves that way.
I'll attach the changed test files separately.
test-data/spreadsheet/FormulaEvalTestData_Copy.xlsx
test-data/spreadsheet/FormulaEvalTestData.xls
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
--- Comment #5 from Javen O'Neal <on...@apache.org> ---
Nevermind, TestFormulasFromSpreadsheet.java handles the extra tests. No need
for new unit tests.
The current attached xls/xlsx files fail at TestFormulasFromSpreadsheet.java
because their locale is DE, so they use OktIndex rather than Oct2Dec, and other
locale-specific functions. However, Offset passes, so the changes are good.
I don't have access to EN locale Excel to copy your edits over at the moment.
I'll get to this in a week if no one else beats me to it. Presumably the only
changes were the addition of Offset formulas:
H1040 =SUM(OFFSET(K7:L8,0,0,1,1))
I1040 =SUM(OFFSET(K7:L8,0,0,1,))
J1040 =SUM(OFFSET(K7:L8,0,0,,1))
K1040 =SUM(OFFSET(K7:L8,0,0,1))
L1040 =SUM(OFFSET(K7:L8,0,0))
M1040 =SUM(OFFSET(K7:L8,0,0,,))
N1040 =SUM(OFFSET(K7:L8,0,0,))
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
--- Comment #7 from Patrick Zimmermann <pa...@haltec.de> ---
As you said, those seven added tests were the only changes in the Excel files.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
--- Comment #1 from Patrick Zimmermann <pa...@haltec.de> ---
Created attachment 33073
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33073&action=edit
FormulaEvalTestData.xls
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
--- Comment #4 from Javen O'Neal <on...@apache.org> ---
Is there an ignored failing unit test to show that the offset function doesn't
work when one or both of the last two parameters are missing? If not, that's
probably all this bug needs before it can be merged.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
--- Comment #3 from Patrick Zimmermann <pa...@haltec.de> ---
Is there anything I can do to get this merged or is it just missing tuits?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #6 from Javen O'Neal <on...@apache.org> ---
Merged in r1730606 and r1730607.
Thanks for the patch, Patrick!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
--- Comment #2 from Patrick Zimmermann <pa...@haltec.de> ---
Created attachment 33074
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33074&action=edit
FormulaEvalTestData_Copy.xlsx
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58339] [PATCH] Make OFFSET() accept missing parameters
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58339
Patrick Zimmermann <pa...@haltec.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org