You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2012/01/12 04:08:59 UTC
svn commit: r1230379 - in /hive/trunk:
ql/src/java/org/apache/hadoop/hive/ql/exec/
ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/
serde/src/java/org/apache/hadoop/hive/serde2/lazy/
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/
Author: hashutosh
Date: Thu Jan 12 03:08:58 2012
New Revision: 1230379
URL: http://svn.apache.org/viewvc?rev=1230379&view=rev
Log:
HIVE-2682: Clean-up logs (Rajat Goel via Ashutosh Chauhan)
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java
hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java?rev=1230379&r1=1230378&r2=1230379&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java Thu Jan 12 03:08:58 2012
@@ -912,12 +912,12 @@ public class GroupByOperator extends Ope
}
hashAggregations.clear();
hashAggregations = null;
- LOG.warn("Hash Table completed flushed");
+ LOG.info("Hash Table completed flushed");
return;
}
int oldSize = hashAggregations.size();
- LOG.warn("Hash Tbl flush: #hash table = " + oldSize);
+ LOG.info("Hash Tbl flush: #hash table = " + oldSize);
Iterator<Map.Entry<KeyWrapper, AggregationBuffer[]>> iter = hashAggregations
.entrySet().iterator();
int numDel = 0;
@@ -927,7 +927,7 @@ public class GroupByOperator extends Ope
iter.remove();
numDel++;
if (numDel * 10 >= oldSize) {
- LOG.warn("Hash Table flushed: new size = " + hashAggregations.size());
+ LOG.info("Hash Table flushed: new size = " + hashAggregations.size());
return;
}
}
@@ -995,7 +995,7 @@ public class GroupByOperator extends Ope
forward(new Object[0], aggregations);
} else {
if (hashAggregations != null) {
- LOG.warn("Begin Hash Table flush at close: size = "
+ LOG.info("Begin Hash Table flush at close: size = "
+ hashAggregations.size());
Iterator iter = hashAggregations.entrySet().iterator();
while (iter.hasNext()) {
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java?rev=1230379&r1=1230378&r2=1230379&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java Thu Jan 12 03:08:58 2012
@@ -109,11 +109,10 @@ public class JoinOperator extends Common
}
} else {
if (sz == nextSz) {
- // Output a warning if we reached at least 1000 rows for a join
- // operand
- // We won't output a warning for the last join operand since the size
+ // Print a message if we reached at least 1000 rows for a join operand
+ // We won't print a message for the last join operand since the size
// will never goes to joinEmitInterval.
- LOG.warn("table " + alias + " has " + sz + " rows for join key "
+ LOG.info("table " + alias + " has " + sz + " rows for join key "
+ keyObject);
nextSz = getNextSize(nextSz);
}
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java?rev=1230379&r1=1230378&r2=1230379&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java Thu Jan 12 03:08:58 2012
@@ -115,7 +115,7 @@ public class JDBCStatsAggregator impleme
public String aggregateStats(String fileID, String statType) {
if (!JDBCStatsUtils.isValidStatistic(statType)) {
- LOG.warn("Warning. Invalid statistic: " + statType + ", supported stats: " +
+ LOG.warn("Invalid statistic: " + statType + ", supported stats: " +
JDBCStatsUtils.getSupportedStatistics());
return null;
}
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java?rev=1230379&r1=1230378&r2=1230379&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java Thu Jan 12 03:08:58 2012
@@ -125,7 +125,8 @@ public class JDBCStatsPublisher implemen
}
if (!JDBCStatsUtils.isValidStatisticSet(stats.keySet())) {
- LOG.warn("Warning. Invalid statistic.");
+ LOG.warn("Invalid statistic:" + stats.keySet().toString() + ", supported "
+ + " stats: " + JDBCStatsUtils.getSupportedStatistics());
return false;
}
LOG.info("Stats publishing for key " + fileID);
Modified: hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
URL: http://svn.apache.org/viewvc/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java?rev=1230379&r1=1230378&r2=1230379&view=diff
==============================================================================
--- hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java (original)
+++ hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java Thu Jan 12 03:08:58 2012
@@ -164,7 +164,7 @@ public class LazyStruct extends LazyNonP
// Missing fields?
if (!missingFieldWarned && fieldId < fields.length) {
missingFieldWarned = true;
- LOG.warn("Missing fields! Expected " + fields.length + " fields but "
+ LOG.info("Missing fields! Expected " + fields.length + " fields but "
+ "only got " + fieldId + "! Ignoring similar problems.");
}
Modified: hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java
URL: http://svn.apache.org/viewvc/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java?rev=1230379&r1=1230378&r2=1230379&view=diff
==============================================================================
--- hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java (original)
+++ hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java Thu Jan 12 03:08:58 2012
@@ -169,7 +169,7 @@ public class LazyBinaryStruct extends
// Missing fields?
if (!missingFieldWarned && lastFieldByteEnd > structByteEnd) {
missingFieldWarned = true;
- LOG.warn("Missing fields! Expected " + fields.length + " fields but "
+ LOG.info("Missing fields! Expected " + fields.length + " fields but "
+ "only got " + fieldId + "! Ignoring similar problems.");
}