You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 11:17:04 UTC

[GitHub] [arrow] Aakash-2904 opened a new pull request #12390: Update contributing.rst

Aakash-2904 opened a new pull request #12390:
URL: https://github.com/apache/arrow/pull/12390


   Made  few changes in the read me part


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ianmcook closed pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ianmcook closed pull request #12390:
URL: https://github.com/apache/arrow/pull/12390


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1046019414


   Benchmark runs are scheduled for baseline = bec777d96970715907785dcbaba18bebc92d2f9e and contender = 5bedee46e5dd488e947a7cb81f4954223a9e2917. 5bedee46e5dd488e947a7cb81f4954223a9e2917 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f0b23ff4b4984b16ac0931d6adc8f390...60837c17d44647468bb2bce3a0b7bb89/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5fd55ff4df564564905a39e266f0a3fc...8e3ab87c2773491282e5f81418364626/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c45689445c3c43fe9698f5d9dc1fb78f...8cb80503d2654cb0aa7639e0de191aaa/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/60958fbe9ddc4d7abbb6ad7c79b31792...00e347e4d2dd4deb8a284892149aeb3b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1046019414


   Benchmark runs are scheduled for baseline = bec777d96970715907785dcbaba18bebc92d2f9e and contender = 5bedee46e5dd488e947a7cb81f4954223a9e2917. 5bedee46e5dd488e947a7cb81f4954223a9e2917 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f0b23ff4b4984b16ac0931d6adc8f390...60837c17d44647468bb2bce3a0b7bb89/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5fd55ff4df564564905a39e266f0a3fc...8e3ab87c2773491282e5f81418364626/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c45689445c3c43fe9698f5d9dc1fb78f...8cb80503d2654cb0aa7639e0de191aaa/)
   [Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/60958fbe9ddc4d7abbb6ad7c79b31792...00e347e4d2dd4deb8a284892149aeb3b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ianmcook commented on pull request #12390: Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1045510567


   One small suggested change, otherwise LGTM. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1034797331


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12390: Update contributing.rst

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1034797331


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1046019414


   Benchmark runs are scheduled for baseline = bec777d96970715907785dcbaba18bebc92d2f9e and contender = 5bedee46e5dd488e947a7cb81f4954223a9e2917. 5bedee46e5dd488e947a7cb81f4954223a9e2917 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f0b23ff4b4984b16ac0931d6adc8f390...60837c17d44647468bb2bce3a0b7bb89/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5fd55ff4df564564905a39e266f0a3fc...8e3ab87c2773491282e5f81418364626/)
   [Failed :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c45689445c3c43fe9698f5d9dc1fb78f...8cb80503d2654cb0aa7639e0de191aaa/)
   [Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/60958fbe9ddc4d7abbb6ad7c79b31792...00e347e4d2dd4deb8a284892149aeb3b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ianmcook commented on a change in pull request #12390: Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#discussion_r810427858



##########
File path: docs/source/developers/contributing.rst
##########
@@ -190,7 +190,7 @@ direct questions, such as:
 
 * Do you think $PROPOSED_APPROACH is the right one?
 * In which file(s) should I be looking to make changes?
-* Is there anything related in the codebase I can look at to learn?
+* Is there anything related to the codebase I can look at to learn?

Review comment:
       ```suggestion
   * Is there anything related in the codebase that I can look at to learn?
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1046019414


   Benchmark runs are scheduled for baseline = bec777d96970715907785dcbaba18bebc92d2f9e and contender = 5bedee46e5dd488e947a7cb81f4954223a9e2917. 5bedee46e5dd488e947a7cb81f4954223a9e2917 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f0b23ff4b4984b16ac0931d6adc8f390...60837c17d44647468bb2bce3a0b7bb89/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5fd55ff4df564564905a39e266f0a3fc...8e3ab87c2773491282e5f81418364626/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c45689445c3c43fe9698f5d9dc1fb78f...8cb80503d2654cb0aa7639e0de191aaa/)
   [Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/60958fbe9ddc4d7abbb6ad7c79b31792...00e347e4d2dd4deb8a284892149aeb3b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12390: MINOR: [Docs] Update contributing.rst

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12390:
URL: https://github.com/apache/arrow/pull/12390#issuecomment-1046019414


   Benchmark runs are scheduled for baseline = bec777d96970715907785dcbaba18bebc92d2f9e and contender = 5bedee46e5dd488e947a7cb81f4954223a9e2917. 5bedee46e5dd488e947a7cb81f4954223a9e2917 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f0b23ff4b4984b16ac0931d6adc8f390...60837c17d44647468bb2bce3a0b7bb89/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5fd55ff4df564564905a39e266f0a3fc...8e3ab87c2773491282e5f81418364626/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c45689445c3c43fe9698f5d9dc1fb78f...8cb80503d2654cb0aa7639e0de191aaa/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/60958fbe9ddc4d7abbb6ad7c79b31792...00e347e4d2dd4deb8a284892149aeb3b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org