You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "chiacyu (via GitHub)" <gi...@apache.org> on 2025/04/03 01:31:34 UTC
[PR] HDDS-12757. Duplicated declaration of dnsInterface in HddsUtils [ozone]
chiacyu opened a new pull request, #8222:
URL: https://github.com/apache/ozone/pull/8222
## What changes were proposed in this pull request?
There're two identical line of below declaration, I think that one of them can be removed.
```java
dnsInterface = conf.get(HDDS_DATANODE_DNS_INTERFACE_KEY);
```
## What is the link to the Apache JIRA
[HDDS-12757](https://issues.apache.org/jira/browse/HDDS-12757)
## How was this patch tested?
CI:
https://github.com/chiacyu/ozone/actions/runs/14224664936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12757. Duplicated declaration of dnsInterface in HddsUtils [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8222:
URL: https://github.com/apache/ozone/pull/8222#issuecomment-2778270665
Thanks @chiacyu for the patch.
I agree with @ChenSammi: please try to avoid single-liner PRs. Running full CI on such a small change is a waste of resources. E.g. make similar changes in multiple files, or completely clean up a single file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12757. Duplicated declaration of dnsInterface in HddsUtils [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8222:
URL: https://github.com/apache/ozone/pull/8222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12757. Duplicated declaration of dnsInterface in HddsUtils [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #8222:
URL: https://github.com/apache/ozone/pull/8222#issuecomment-2774335002
@chiacyu , thanks for working on this to improve the code. I'm just wondering if you can consolidate a few of these kinds of improvements into one JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org