You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 17:33:28 UTC

[GitHub] [flink] zentol commented on a change in pull request #19195: [FLINK-26798][runtime] Hardens test against unexpected heartbeat

zentol commented on a change in pull request #19195:
URL: https://github.com/apache/flink/pull/19195#discussion_r837734753



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
##########
@@ -2025,9 +2009,8 @@ private void runJobFailureWhenTaskExecutorTerminatesTest(
                                         return CompletableFuture.completedFuture(Acknowledge.get());
                                     })
                             .setHeartbeatJobManagerFunction(
-                                    heartbeatConsumerFunction.apply(
-                                            jobMasterGateway,
-                                            taskManagerUnresolvedLocation.getResourceID()))
+                                    (ignoredResourceId, ignoredAllocationSlotReport) ->
+                                            FutureUtils.completedVoidFuture())

Review comment:
       this is the default behavior of the builder; so we don't even need to set a function at all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org