[jira] [Commented] (VFS-353) [FTP] Client should call logout before disconnecting

["Gary D. Gregory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VFS-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276959#comment-13276959 ] 

Gary D. Gregory commented on VFS-353:
-------------------------------------

Note that the unit tests now log this error to the console without affecting the tests negatively it seems:

{noformat}
Running org.apache.commons.vfs2.provider.ftp.test.FtpProviderTestCase
2012-05-16 12:48:33,907 [pool-3-thread-2] ERROR: Exception caught, closing session
java.io.IOException: An established connection was aborted by the software in your host machine
        at sun.nio.ch.SocketDispatcher.read0(Native Method)
        at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:25)
        at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:198)
        at sun.nio.ch.IOUtil.read(IOUtil.java:171)
        at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:243)
        at org.apache.mina.transport.socket.nio.NioProcessor.read(NioProcessor.java:280)
        at org.apache.mina.transport.socket.nio.NioProcessor.read(NioProcessor.java:44)
        at org.apache.mina.core.polling.AbstractPollingIoProcessor.read(AbstractPollingIoProcessor.java:695)
        at org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:668)
        at org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:657)
        at org.apache.mina.core.polling.AbstractPollingIoProcessor.access$600(AbstractPollingIoProcessor.java:68)
        at org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:1141)
        at org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)
Tests run: 63, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.732 sec
Running org.apache.commons.vfs2.provider.ftp.test.MultipleConnectionTestCase
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec
{noformat}

This could be a misuse of Apache Commons Net by missing making a call to org.apache.commons.net.ftp.FTPClient.completePendingCommand() in just the right spot.
                
> [FTP] Client should call logout before disconnecting
> ----------------------------------------------------
>
>                 Key: VFS-353
>                 URL: https://issues.apache.org/jira/browse/VFS-353
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Andreas Bergander
>              Labels: ftp, logout
>             Fix For: 2.1
>
>
> Before the disconnect method is called, which closes the sockets, an FTP QUIT command should be sent by calling the logout-method.
> This is the polite way of ending an FTP session. Some FTP servers don't like if the QUIT command is skipped and eventually disallows further connection attempts after a while.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira