You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/08/25 00:08:28 UTC
[kudu-CR] TestSecurity: remove errant Precondition
Hello Dan Burkert, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11325
to review the following change.
Change subject: TestSecurity: remove errant Precondition
......................................................................
TestSecurity: remove errant Precondition
Its presence makes it impossible to retry the tests in this class.
An alternative would be to null out miniCluster in tearDown(), but I don't
think that should be necessary for creating a new cluster.
Change-Id: I0ba826d3ec722cb20b35d4c34817d30ab9782976
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/11325/1
--
To view, visit http://gerrit.cloudera.org:8080/11325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ba826d3ec722cb20b35d4c34817d30ab9782976
Gerrit-Change-Number: 11325
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] TestSecurity: remove errant Precondition
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11325 )
Change subject: TestSecurity: remove errant Precondition
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ba826d3ec722cb20b35d4c34817d30ab9782976
Gerrit-Change-Number: 11325
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 00:10:31 +0000
Gerrit-HasComments: No
[kudu-CR] TestSecurity: remove errant Precondition
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11325 )
Change subject: TestSecurity: remove errant Precondition
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ba826d3ec722cb20b35d4c34817d30ab9782976
Gerrit-Change-Number: 11325
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 02:33:37 +0000
Gerrit-HasComments: No
[kudu-CR] TestSecurity: remove errant Precondition
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11325 )
Change subject: TestSecurity: remove errant Precondition
......................................................................
TestSecurity: remove errant Precondition
Its presence makes it impossible to retry the tests in this class.
An alternative would be to null out miniCluster in tearDown(), but I don't
think that should be necessary for creating a new cluster.
Change-Id: I0ba826d3ec722cb20b35d4c34817d30ab9782976
Reviewed-on: http://gerrit.cloudera.org:8080/11325
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ba826d3ec722cb20b35d4c34817d30ab9782976
Gerrit-Change-Number: 11325
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins