You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/26 14:32:14 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #9229: [FLINK-13279][table-sql-client] Fully qualify sink name in sql-client

dawidwys commented on a change in pull request #9229:  [FLINK-13279][table-sql-client] Fully qualify sink name in sql-client 
URL: https://github.com/apache/flink/pull/9229#discussion_r307769851
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
 ##########
 @@ -151,6 +155,44 @@ public void testValidateSession() throws Exception {
 		assertEquals(expectedTables, actualTables);
 	}
 
+	@Test(timeout = 30_000L)
+	public void testDefaultCatalogDifferentFromBuiltin() throws Exception {
 
 Review comment:
   I agree. I also don't like the test. I couldn't find a well isolated way to test this behavior though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services