You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/01/14 09:49:09 UTC
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2696: [SCB-2369] improve fow control logs and message
codecov-commenter commented on pull request #2696:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2696#issuecomment-1012965479
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2696](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d26d4a) into [1.3.x](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/e2043529758ca639adc0b6ddc56408507e3f1129?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e204352) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.3.x #2696 +/- ##
============================================
- Coverage 82.99% 82.99% -0.01%
Complexity 746 746
============================================
Files 1233 1233
Lines 33075 33082 +7
Branches 3000 3001 +1
============================================
+ Hits 27451 27456 +5
- Misses 4439 4441 +2
Partials 1185 1185
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../servicecomb/demo/pojo/client/TestFlowControl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvVGVzdEZsb3dDb250cm9sLmphdmE=) | `92.85% <100.00%> (ø)` | |
| [...servicecomb/qps/ConsumerQpsFlowControlHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9Db25zdW1lclFwc0Zsb3dDb250cm9sSGFuZGxlci5qYXZh) | `75.00% <100.00%> (ø)` | |
| [...servicecomb/qps/ProviderQpsFlowControlHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9Qcm92aWRlclFwc0Zsb3dDb250cm9sSGFuZGxlci5qYXZh) | `87.50% <100.00%> (ø)` | |
| [.../servicecomb/qps/strategy/FixedWindowStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9zdHJhdGVneS9GaXhlZFdpbmRvd1N0cmF0ZWd5LmphdmE=) | `76.47% <100.00%> (+9.80%)` | :arrow_up: |
| [.../servicecomb/qps/strategy/LeakyBucketStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9zdHJhdGVneS9MZWFreUJ1Y2tldFN0cmF0ZWd5LmphdmE=) | `85.71% <100.00%> (+1.50%)` | :arrow_up: |
| [...in/java/org/apache/servicecomb/core/SCBEngine.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9TQ0JFbmdpbmUuamF2YQ==) | `81.57% <0.00%> (-1.58%)` | :arrow_down: |
| [.../org/apache/servicecomb/provider/pojo/Invoker.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vSW52b2tlci5qYXZh) | `94.36% <0.00%> (-1.41%)` | :arrow_down: |
| [...icecomb/demo/springmvc/client/SpringmvcClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXNwcmluZ212Yy9zcHJpbmdtdmMtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL3NwcmluZ212Yy9jbGllbnQvU3ByaW5nbXZjQ2xpZW50LmphdmE=) | `83.73% <0.00%> (-0.48%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `62.27% <0.00%> (+0.39%)` | :arrow_up: |
| [...egistry/client/LocalServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9Mb2NhbFNlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `80.09% <0.00%> (+0.46%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e204352...0d26d4a](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2696?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org