You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/17 05:25:34 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #8850: working!

rusackas opened a new pull request #8850: working!
URL: https://github.com/apache/incubator-superset/pull/8850
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   A previous PR added version number and SHA (when avaialable) to the user menu in the top right. The Menu was then refactored to React (yay!) and this feature was lost (doh!). This PR restores it, but in the new menu construct. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Pulls from version_info.json:
   ![image](https://user-images.githubusercontent.com/812905/70967136-483f5400-204a-11ea-9c2c-7f729d42d7b1.png)
   
   Or from package.json (no SHA)
   ![image](https://user-images.githubusercontent.com/812905/70967171-6311c880-204a-11ea-9f96-33ac52a6e244.png)
   
   The length of the SHA is configurable in config.py, for those that like a longer SHA.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Unit test added :)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @nytai @robdiciuccio 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org