You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/12/30 04:10:28 UTC
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/3834
[SPARK-4908][SQL] Prevent multiple concurrent hive native commands
This is just a quick fix that locks when calling `runHive`. If we can find a way to avoid the error without a global lock that would be better.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark hiveConcurrency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3834
----
commit bf25300ffbebdf7a313c6bc39e940ab75c357e67
Author: Michael Armbrust <mi...@databricks.com>
Date: 2014-12-30T03:09:20Z
prevent multiple concurrent hive native commands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3834#issuecomment-68329208
[Test build #24879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24879/consoleFull) for PR 3834 at commit [`bf25300`](https://github.com/apache/spark/commit/bf25300ffbebdf7a313c6bc39e940ab75c357e67).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3834#issuecomment-68326513
[Test build #24879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24879/consoleFull) for PR 3834 at commit [`bf25300`](https://github.com/apache/spark/commit/bf25300ffbebdf7a313c6bc39e940ab75c357e67).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3834#issuecomment-68330655
According to my earlier investigation, this issue seems to be related to the asynchronous execution feature enabled by default in Hive 0.13.1 JDBC driver. I'm not pretty sure whether synchronizes `HiveContext.runHive` completely fixes this issue. But I'd vote to merge this first before we find the root cause, since doing so does no harm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3834#issuecomment-68692301
Just for reference, the root cause behind this issue is discussed in [SPARK-4908] [1].
[1]: https://issues.apache.org/jira/browse/SPARK-4908?focusedCommentId=14264469&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14264469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3834#issuecomment-68329213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24879/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4908][SQL] Prevent multiple concurrent ...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3834#issuecomment-68388133
Merged to master and branch-1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org