You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/06 18:38:47 UTC

[GitHub] [netbeans] matthiasblaesing commented on pull request #4739: Dialog parent main window instead of null

matthiasblaesing commented on PR #4739:
URL: https://github.com/apache/netbeans/pull/4739#issuecomment-1270523228

   I noticed, that at least in some cases the class, that opens the dialog is itself an instance of `java.awt.Component`. In that case it could be passed to `JFileChooser#show*Dialog` and Swing would be responsible to find the right `JFrame` which should be the parent of the dialog. That relieves the need to fiddle with the main window or the keyboard focus or whatever and makes the code easier to follow. This should apply to `TemplatesPanel.java`, `LoadGeneratorCustomizer.java`, `LocationCustomizer.java` and `SnapshotCustomizer.java`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists