You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "MiniSho (via GitHub)" <gi...@apache.org> on 2023/08/02 09:31:22 UTC
[GitHub] [iotdb] MiniSho opened a new pull request, #10762: [IOTDB-6094] Load：Fix construct tsFileResource bug
MiniSho opened a new pull request, #10762:
URL: https://github.com/apache/iotdb/pull/10762
## Description
In a benchmark scenario with 500 devices and 50 sensors, the load gives a No Such File error.
<img width="1177" alt="image" src="https://github.com/apache/iotdb/assets/42286868/834a294b-337a-4327-9627-06fc7fb571bc">
## Reason
`constructTsFileResource` only update the tsfile resource information and does not create a file, then every time it determines whether the file exists, it determines that the file doesn't exist and causes it to go to the wrong branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SpriCoder commented on pull request #10762: [IOTDB-6094] Load: Fix error in if/else judgment of tsfileResource exists or not
Posted by "SpriCoder (via GitHub)" <gi...@apache.org>.
SpriCoder commented on PR #10762:
URL: https://github.com/apache/iotdb/pull/10762#issuecomment-1662124967
The Chinese and English descriptions are comprehensive, while the code is brief and competent. IoTDB's loading functionality simply cannot function without your assistance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] lancelly commented on pull request #10762: [IOTDB-6094] Load: Fix error in if/else judgment of tsfileResource exists or not
Posted by "lancelly (via GitHub)" <gi...@apache.org>.
lancelly commented on PR #10762:
URL: https://github.com/apache/iotdb/pull/10762#issuecomment-1662126771
Nobody knows load better than you🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SzyWilliam commented on pull request #10762: [IOTDB-6094] Load: Fix error in if/else judgment of tsfileResource exists or not
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on PR #10762:
URL: https://github.com/apache/iotdb/pull/10762#issuecomment-1662123133
Bravo work, Lord of Load!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #10762: [IOTDB-6094] Load: Fix error in if/else judgment of tsfileResource exists or not & Reduce warn log when timeseries exist
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #10762:
URL: https://github.com/apache/iotdb/pull/10762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org