You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2019/10/21 13:21:13 UTC
[asterixdb] 04/05: [NO ISSUE][NET] Exclude Warn Logs When No Buffer
Factory is Used
This is an automated email from the ASF dual-hosted git repository.
mblow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit a9ab32e3f14ebef15ee553118bd05f4fc024babe
Author: Murtadha Hubail <mh...@apache.org>
AuthorDate: Fri Oct 18 22:04:05 2019 +0300
[NO ISSUE][NET] Exclude Warn Logs When No Buffer Factory is Used
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Do not warn about recycled partial frames when no buffer
factory is set in FullFrameChannelReadInterface as those
are valid cases that use a single frame to perform the
complete operation.
Change-Id: I80251c529eb15ee22d01c320883418ea80272c2c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3824
Reviewed-by: Murtadha Hubail <mh...@apache.org>
Reviewed-by: Till Westmann <ti...@apache.org>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
.../hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
index 9d7f848..0ce5a87 100644
--- a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
+++ b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
@@ -47,7 +47,7 @@ public class FullFrameChannelReadInterface extends AbstractChannelReadInterface
credits = 0;
emptyBufferAcceptor = buffer -> {
final int delta = buffer.remaining();
- if (delta != frameSize) {
+ if (bufferFactory != null && delta != frameSize) {
LOGGER.warn("partial frame being recycled; expected size {}, actual size {}", frameSize, delta);
}
synchronized (bufferRecycleLock) {