You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/14 09:59:08 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5491: Removed a lot of compiler warnings. Part 2
tbw777 opened a new pull request, #5491:
URL: https://github.com/apache/netbeans/pull/5491
Inserted diamond in constructions like this:
`ArrayList<Strings> = new ArrayList();`
No any interfaces was changed
Part 2:
Replaced on already defined generics:
```
Collections.EMPTY_SET -> Collections.emptySet()
Collections.EMPTY_LIST -> Collections.emptyList()
Collections.EMPTY_MAP -> Collections.emptyMap()
```
Previos part 1: #5487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1429790958
Here's what I would suggest and what I've previously done..
Reduce this check-in to 3 separate PRs. One for each of EMPTY_SET, EMPTY_LIST, and EMPTY_MAP.
It's just too large for me. But, if you do this, I will promptly review it.
Keep things simple. Really simple and you much more likely to get help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1431010038
i lost all changes ))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1431015857
recovered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1430826311
@tbw777 I believe you misunderstood what @BradWalker said here: https://github.com/apache/netbeans/pull/5491#issuecomment-1429790958
please do the following:
- remove the two commits which do the diamond changes since this PR is already large enough
- split the empty collection commit into 3: one for Set, one for Map, one for List
- force push into this PR
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 closed pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5491: Removed a lot of compiler warnings. Part 2
URL: https://github.com/apache/netbeans/pull/5491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1430025088
simply force push into this PR. no need to start new ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1429763535
DefaultComboBoxModel will be refactor in the feature in separate PRs, therefore excluded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1429740367
Thereis a more difficult search patterns was found, for example
two lines:
```
List<String> test = condition ? Empty
: new ArrayList()
```
And so on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1430021577
we can do one PR, 3 commits. review and then squash before merge. This conserves resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1430062001
@mbien , works for me..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1429728843
I did a substantial amount of cleanup in this area previously.
I count 149 remaining examples of this. Why is your code change much more than this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5491: Removed a lot of compiler warnings. Part 2
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5491:
URL: https://github.com/apache/netbeans/pull/5491#issuecomment-1430068698
> we can do one PR, 3 commits. review and then squash before merge.
Also, those seem fine as 3 commits to me without squashing - potentially worth keeping in history as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists