You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/12 14:34:47 UTC
[GitHub] [ozone] guihecheng opened a new pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
guihecheng opened a new pull request #2243:
URL: https://github.com/apache/ozone/pull/2243
## What changes were proposed in this pull request?
Datanode has config 'dfs.datanode.failed.volumes.tolerated', but it does not work,
this makes it to work.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5219
## How was this patch tested?
a new integration-test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r637816445
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
##########
@@ -123,6 +127,18 @@ public void setBlockDeletionLimit(int limit) {
private long periodicDiskCheckIntervalMinutes =
PERIODIC_DISK_CHECK_INTERVAL_MINUTES_DEFAULT;
+ @Config(key = "failed.volumes.tolerated",
+ defaultValue = "0",
Review comment:
I feel, we should make the default as -1 rather than zero by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634993201
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -267,14 +272,26 @@ void checkAllVolumes() throws IOException {
* Handle one or more failed volumes.
* @param failedVolumes
*/
- private void handleVolumeFailures(Set<HddsVolume> failedVolumes) {
+ private void handleVolumeFailures(Set<HddsVolume> failedVolumes)
+ throws IOException {
this.writeLock();
try {
for (HddsVolume v : failedVolumes) {
// Immediately mark the volume as failed so it is unavailable
// for new containers.
failVolume(v.getHddsRootDir().getPath());
}
+
+ // check failed volume tolerated
+ if (!hasEnoughVolumes()) {
Review comment:
Can we move this part out of lock protection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634968898
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
return ImmutableMap.copyOf(volumeStateMap);
}
+ public boolean hasEnoughVolumes() {
+ int maxVolumeFailuresTolerated = conf.getInt(
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_DEFAULT);
+
+ if (maxVolumeFailuresTolerated ==
+ DataNode.MAX_VOLUME_FAILURE_TOLERATED_LIMIT) {
+ return getVolumesList().size() >= 1;
+ } else {
+ return getFailedVolumesList().size() <= maxVolumeFailuresTolerated;
Review comment:
What's the difference of if else here, could you do a little explaination?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634988601
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
##########
@@ -262,6 +262,11 @@ private void start() throws IOException {
}
}
+ public void handleFatalVolumeFailures() {
+ LOG.error("DatanodeStateMachine Shutdown due to fatal volume failures");
Review comment:
A more detail error message is preferred here since we know the right reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634987991
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
return ImmutableMap.copyOf(volumeStateMap);
}
+ public boolean hasEnoughVolumes() {
+ int maxVolumeFailuresTolerated = conf.getInt(
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,
Review comment:
@ChenSammi oh, then I shall add this key in some other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r637830756
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
##########
@@ -123,6 +127,18 @@ public void setBlockDeletionLimit(int limit) {
private long periodicDiskCheckIntervalMinutes =
PERIODIC_DISK_CHECK_INTERVAL_MINUTES_DEFAULT;
+ @Config(key = "failed.volumes.tolerated",
+ defaultValue = "0",
Review comment:
@bshashikant here I borrowed the default 0 from HDFS to stay aligned, but I also think that -1 is reasonable.
With -1 as the default, we introduce no behavioral change to existing clusters when we have a few(1~2) volumes failed.
Will update, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #2243:
URL: https://github.com/apache/ozone/pull/2243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634989567
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
return ImmutableMap.copyOf(volumeStateMap);
}
+ public boolean hasEnoughVolumes() {
+ int maxVolumeFailuresTolerated = conf.getInt(
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_DEFAULT);
+
+ if (maxVolumeFailuresTolerated ==
+ DataNode.MAX_VOLUME_FAILURE_TOLERATED_LIMIT) {
+ return getVolumesList().size() >= 1;
+ } else {
+ return getFailedVolumesList().size() <= maxVolumeFailuresTolerated;
Review comment:
This logic is borrowed from hdfs, when we set this 'tolerated' to -1, we mean unlimited number of bad volumes but we still should have at least 1 good volume left.
Otherwise, we should have fewer or equal number of bad volumes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634994328
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -267,14 +272,26 @@ void checkAllVolumes() throws IOException {
* Handle one or more failed volumes.
* @param failedVolumes
*/
- private void handleVolumeFailures(Set<HddsVolume> failedVolumes) {
+ private void handleVolumeFailures(Set<HddsVolume> failedVolumes)
+ throws IOException {
this.writeLock();
try {
for (HddsVolume v : failedVolumes) {
// Immediately mark the volume as failed so it is unavailable
// for new containers.
failVolume(v.getHddsRootDir().getPath());
}
+
+ // check failed volume tolerated
+ if (!hasEnoughVolumes()) {
+ // on startup, we could not try to stop uninitialized services
+ if (shutdownHook == null) {
+ throw new IOException("Don't have enough volumes to startup.");
Review comment:
Prefer more detail error message, such as how may volumes configured, and how many failed volumes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634991007
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
##########
@@ -262,6 +262,11 @@ private void start() throws IOException {
}
}
+ public void handleFatalVolumeFailures() {
+ LOG.error("DatanodeStateMachine Shutdown due to fatal volume failures");
Review comment:
sure, I'll put a more clear message here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634966390
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -102,15 +105,17 @@
private Runnable shutdownHook;
private final HddsVolumeChecker volumeChecker;
private Runnable failedVolumeListener;
+ private StateContext context;
- public MutableVolumeSet(String dnUuid, ConfigurationSource conf)
- throws IOException {
- this(dnUuid, null, conf);
+ public MutableVolumeSet(String dnUuid, ConfigurationSource conf,
+ StateContext context) throws IOException {
Review comment:
Indent is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#issuecomment-843943068
@guihecheng , thanks for the work. The config needs to be defined in ozone-site.xml and should be well documented in ozone-default.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634964960
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
return ImmutableMap.copyOf(volumeStateMap);
}
+ public boolean hasEnoughVolumes() {
+ int maxVolumeFailuresTolerated = conf.getInt(
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,
Review comment:
DFSConfigKeysLegacy is a deprecated Class. Since Ozone is spinned out from Hadoop, as a new project, we should avoid use HDFS configuration key anymore. We can define a similar key for Ozone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r635087420
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
return ImmutableMap.copyOf(volumeStateMap);
}
+ public boolean hasEnoughVolumes() {
+ int maxVolumeFailuresTolerated = conf.getInt(
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_DEFAULT);
+
+ if (maxVolumeFailuresTolerated ==
+ DataNode.MAX_VOLUME_FAILURE_TOLERATED_LIMIT) {
+ return getVolumesList().size() >= 1;
+ } else {
+ return getFailedVolumesList().size() <= maxVolumeFailuresTolerated;
Review comment:
Can you add some comments here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r635008636
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -267,14 +272,26 @@ void checkAllVolumes() throws IOException {
* Handle one or more failed volumes.
* @param failedVolumes
*/
- private void handleVolumeFailures(Set<HddsVolume> failedVolumes) {
+ private void handleVolumeFailures(Set<HddsVolume> failedVolumes)
+ throws IOException {
this.writeLock();
try {
for (HddsVolume v : failedVolumes) {
// Immediately mark the volume as failed so it is unavailable
// for new containers.
failVolume(v.getHddsRootDir().getPath());
}
+
+ // check failed volume tolerated
+ if (!hasEnoughVolumes()) {
+ // on startup, we could not try to stop uninitialized services
+ if (shutdownHook == null) {
+ throw new IOException("Don't have enough volumes to startup.");
Review comment:
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#issuecomment-840984461
Hi @bshashikant @ChenSammi , the config support is added as you suggested, please help review this, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#issuecomment-847466460
@bshashikant updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r635093089
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
return ImmutableMap.copyOf(volumeStateMap);
}
+ public boolean hasEnoughVolumes() {
+ int maxVolumeFailuresTolerated = conf.getInt(
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,
+ DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_DEFAULT);
+
+ if (maxVolumeFailuresTolerated ==
+ DataNode.MAX_VOLUME_FAILURE_TOLERATED_LIMIT) {
+ return getVolumesList().size() >= 1;
+ } else {
+ return getFailedVolumesList().size() <= maxVolumeFailuresTolerated;
Review comment:
@bshashikant sure, will cp the lines above into code comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634988201
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -102,15 +105,17 @@
private Runnable shutdownHook;
private final HddsVolumeChecker volumeChecker;
private Runnable failedVolumeListener;
+ private StateContext context;
- public MutableVolumeSet(String dnUuid, ConfigurationSource conf)
- throws IOException {
- this(dnUuid, null, conf);
+ public MutableVolumeSet(String dnUuid, ConfigurationSource conf,
+ StateContext context) throws IOException {
Review comment:
will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org