You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/01/06 08:37:15 UTC
[GitHub] storm pull request #1864: STORM-2176 Workers do not shutdown cleanly and wor...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1864
STORM-2176 Workers do not shutdown cleanly and worker hooks don't run when a topology is killed
* increase supervisor.worker.shutdown.sleep.secs to let workers kill themselves first even stuck
* disable shutdown hook for log4j2 to make sure logs are written after shutdown is started
Please note that I didn't touch JVM's shutdown hook (leaving it to sleep 1 sec and halt) given that 1 sec looks enough if there's no issue on the worker. In fact shutdown hook shouldn't take too much time.
Given that this is blocker for releasing 1.0.3 and 1.1.0, please review soon so that we can go ahead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1864.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1864
----
commit 296828704431e9e481a470e1f2ee6ac8aa15c865
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-01-06T08:21:05Z
STORM-2176 Workers do not shutdown cleanly and worker hooks don't run when a topology is killed
* increase supervisor.worker.shutdown.sleep.secs to let workers kill themselves first even stuck
* disable shutdown hook for log4j2 to make sure logs are written after shutdown is started
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1864: STORM-2176 Workers do not shutdown cleanly and worker hoo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1864
cherry-picking will work for 1.x and 1.0.x branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1864: STORM-2176 Workers do not shutdown cleanly and worker hoo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1864
@ptgoetz Could you test my patch to see it can resolve STORM-2176 pretty well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1864: STORM-2176 Workers do not shutdown cleanly and worker hoo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1864
+1
In local mode, I found that the JVM never exits, but that's likely a different issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1864: STORM-2176 Workers do not shutdown cleanly and worker hoo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1864
@ptgoetz Ping again. I think we can start release process for 1.0.3 after this, so would like to review this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1864: STORM-2176 Workers do not shutdown cleanly and wor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1864
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---