You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/20 07:49:33 UTC
[GitHub] [flink] Sxnan opened a new pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Sxnan opened a new pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151
## What is the purpose of the change
This pull request translates [Google Cloud PubSub](https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/connectors/pubsub.html) page of connectors into Chinese
## Brief change log
- Translate the markdown file located at flink/docs/dev/connectors/pubsub.zh.md
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149774919) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342)
* abb918ce3a00f39036b019a1eeb3e49dd91910b8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150423224)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
}, {
"hash" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"triggerType" : "PUSH"
}, {
"hash" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155570388",
"triggerID" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* abb918ce3a00f39036b019a1eeb3e49dd91910b8 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/150423224)
* 45d6384bd0f1017bc126d17bb7fe8e32e12ea488 UNKNOWN
* 64c8f81dbd0795c3ec6a0e781702777e65851fb9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155570388)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383106631
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -143,22 +135,22 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### 精确一次语义保证
#### SourceFunction
-There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
+有很多原因导致会一个信息会被多次发出，例如 Google PubSub 的故障。
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+另一个可能的原因是超过了确认的截止时间。这是收到信息的间隔和信息确认的间隔。PubSubSource 只有在信息被成功快照之后才会确认以保证至少一次的语义。这意味着，如果你的快照间隔大于信息确认的截止时间，那么你订阅的信息很有可能会被多次处理。
-For this reason it's recommended to have a (much) lower checkpoint interval than acknowledgement deadline.
+因此，我们建议把快照的间隔设置得比信息确认截止时间更短。
-See [PubSub](https://cloud.google.com/pubsub/docs/subscriber) for details on how to increase the acknowledgment deadline of your subscription.
+参照 [PubSub](https://cloud.google.com/pubsub/docs/subscriber) 来增加信息确认截止时间。
-Note: The metric `PubSubMessagesProcessedNotAcked` shows how many messages are waiting for the next checkpoint before they will be acknowledged.
+注意: `PubSubMessagesProcessedNotAcked` 显示了有多少信息正在等待下一个快照还没被确认。
#### SinkFunction
-The sink function buffers messages that are to be send to PubSub for a short amount of time for performance reasons. Before each checkpoint this buffer is flushed and the checkpoint will not succeed unless the messages have been delivered to PubSub.
+Sink function 会把准备发到 PubSub 的信息短暂地缓存以提高性能。每次快照前，它会 flush 缓冲区，并且只有当所有信息成功发送到 PubSub 之后，快照才会成功完成。
Review comment:
Same issue of "checkpoint" here. I think "flush" can be translated as "刷新".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Sxnan commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383667086
##########
File path: docs/dev/connectors/pubsub.md
##########
@@ -143,13 +143,13 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### At least once guarantee
#### SourceFunction
There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee at-least-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
Review comment:
nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
}, {
"hash" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"triggerType" : "PUSH"
}, {
"hash" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155570388",
"triggerID" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"triggerType" : "PUSH"
}, {
"hash" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6685",
"triggerID" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45d6384bd0f1017bc126d17bb7fe8e32e12ea488 UNKNOWN
* 64c8f81dbd0795c3ec6a0e781702777e65851fb9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/155570388) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6685)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Sxnan commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383665364
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -39,24 +37,17 @@ following dependency to your project:
<b>Note</b>: This connector has been added to Flink recently. It has not received widespread testing yet.
</p>
-Note that the streaming connectors are currently not part of the binary
-distribution. See
-[here]({{ site.baseurl }}/dev/projectsetup/dependencies.html)
-for information about how to package the program with the libraries for
-cluster execution.
-
-
+注意连接器目前还不是二进制发行版的一部分，添加依赖、打包配置以及集群运行信息请参考[这里]({{ site.baseurl }}/dev/projectsetup/dependencies.html)
## Consuming or Producing PubSubMessages
-The connector provides a connectors for receiving and sending messages from and to Google PubSub.
-Google PubSub has an `at-least-once` guarantee and as such the connector delivers the same guarantees.
+连接器可以接收和发送 Google PubSub 的信息。和 Google PubSub 一样，这个连接器能够保证`至少一次`的语义。
### PubSub SourceFunction
-The class `PubSubSource` has a builder to create PubSubsources: `PubSubSource.newBuilder(...)`
+`PubSubSource` 类的对象由构建类来构建: `PubSubSource.newBuilder(...)`
-There are several optional methods to alter how the PubSubSource is created, the bare minimum is to provide a Google project, Pubsub subscription and a way to deserialize the PubSubMessages.
+除了 Google project，Pubsub subscription 和反序列化 PubSubMessage的方法是必须的，你有多种可选的方法来创建 PubSubSource。
Review comment:
Thanks for the suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r398508403
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -143,22 +135,22 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### 精确一次语义保证
Review comment:
```suggestion
### 至少一次语义保证
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149774919) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383101507
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -23,9 +23,7 @@ specific language governing permissions and limitations
under the License.
-->
-This connector provides a Source and Sink that can read from and write to
-[Google Cloud PubSub](https://cloud.google.com/pubsub). To use this connector, add the
-following dependency to your project:
+这个连接器可向 [Google Cloud PubSub](https://cloud.google.com/pubsub) 读取与写入数据。添加下面的依赖来使用此连接器:
Review comment:
"Source and Sink" is not shown in the translated sentence
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
}, {
"hash" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* abb918ce3a00f39036b019a1eeb3e49dd91910b8 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/150423224)
* 45d6384bd0f1017bc126d17bb7fe8e32e12ea488 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
Hash:89d26f578174d90ce9979f076346376bf3597a5b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149774919 TriggerType:PUSH TriggerID:89d26f578174d90ce9979f076346376bf3597a5b
-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149774919)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588705948
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 89d26f578174d90ce9979f076346376bf3597a5b (Thu Feb 20 07:51:39 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-596777195
@PatrickRen Let me know when the PR is in a good shape. I'm happy to merge the PR once it's ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383106065
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -143,22 +135,22 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### 精确一次语义保证
#### SourceFunction
-There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
+有很多原因导致会一个信息会被多次发出，例如 Google PubSub 的故障。
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+另一个可能的原因是超过了确认的截止时间。这是收到信息的间隔和信息确认的间隔。PubSubSource 只有在信息被成功快照之后才会确认以保证至少一次的语义。这意味着，如果你的快照间隔大于信息确认的截止时间，那么你订阅的信息很有可能会被多次处理。
-For this reason it's recommended to have a (much) lower checkpoint interval than acknowledgement deadline.
+因此，我们建议把快照的间隔设置得比信息确认截止时间更短。
-See [PubSub](https://cloud.google.com/pubsub/docs/subscriber) for details on how to increase the acknowledgment deadline of your subscription.
+参照 [PubSub](https://cloud.google.com/pubsub/docs/subscriber) 来增加信息确认截止时间。
-Note: The metric `PubSubMessagesProcessedNotAcked` shows how many messages are waiting for the next checkpoint before they will be acknowledged.
+注意: `PubSubMessagesProcessedNotAcked` 显示了有多少信息正在等待下一个快照还没被确认。
Review comment:
I think we don't need to translate "checkpoint" according to Flink Translation Specifications
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
Hash:89d26f578174d90ce9979f076346376bf3597a5b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149774919 TriggerType:PUSH TriggerID:89d26f578174d90ce9979f076346376bf3597a5b
Hash:89d26f578174d90ce9979f076346376bf3597a5b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342 TriggerType:PUSH TriggerID:89d26f578174d90ce9979f076346376bf3597a5b
-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149774919) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383103168
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -77,13 +68,13 @@ streamExecEnv.addSource(source);
</div>
</div>
-Currently the source functions [pulls](https://cloud.google.com/pubsub/docs/pull) messages from PubSub, [push endpoints](https://cloud.google.com/pubsub/docs/push) are not supported.
+当前还不支持 PubSub 的source functions [pulls](https://cloud.google.com/pubsub/docs/pull) messages和 [push endpoints](https://cloud.google.com/pubsub/docs/push)。
Review comment:
PubSub 的[space]source functions ... messages[space]和...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Sxnan commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383664368
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -23,9 +23,7 @@ specific language governing permissions and limitations
under the License.
-->
-This connector provides a Source and Sink that can read from and write to
-[Google Cloud PubSub](https://cloud.google.com/pubsub). To use this connector, add the
-following dependency to your project:
+这个连接器可向 [Google Cloud PubSub](https://cloud.google.com/pubsub) 读取与写入数据。添加下面的依赖来使用此连接器:
Review comment:
I am not translating the Source and Sink" to keep it consistent with the opening of other connectors such as https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/connectors/filesystem_sink.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
}, {
"hash" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"triggerType" : "PUSH"
}, {
"hash" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155570388",
"triggerID" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"triggerType" : "PUSH"
}, {
"hash" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6685",
"triggerID" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45d6384bd0f1017bc126d17bb7fe8e32e12ea488 UNKNOWN
* 64c8f81dbd0795c3ec6a0e781702777e65851fb9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155570388) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6685)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
}, {
"hash" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"triggerType" : "PUSH"
}, {
"hash" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64c8f81dbd0795c3ec6a0e781702777e65851fb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* abb918ce3a00f39036b019a1eeb3e49dd91910b8 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/150423224)
* 45d6384bd0f1017bc126d17bb7fe8e32e12ea488 UNKNOWN
* 64c8f81dbd0795c3ec6a0e781702777e65851fb9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
rmetzger edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-596777195
@PatrickRen Thanks a lot for your review! Let me know when the PR is in a good shape. I'm happy to merge the PR once it's ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149774919) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342)
* abb918ce3a00f39036b019a1eeb3e49dd91910b8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
Hash:89d26f578174d90ce9979f076346376bf3597a5b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149774919 TriggerType:PUSH TriggerID:89d26f578174d90ce9979f076346376bf3597a5b
Hash:89d26f578174d90ce9979f076346376bf3597a5b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342 TriggerType:PUSH TriggerID:89d26f578174d90ce9979f076346376bf3597a5b
-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149774919) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383107003
##########
File path: docs/dev/connectors/pubsub.md
##########
@@ -143,13 +143,13 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### At least once guarantee
#### SourceFunction
There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee at-least-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
Review comment:
I think using lower case for all three words is better: "at-least-once"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Sxnan commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383669171
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -143,22 +135,22 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### 精确一次语义保证
#### SourceFunction
-There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
+有很多原因导致会一个信息会被多次发出，例如 Google PubSub 的故障。
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+另一个可能的原因是超过了确认的截止时间。这是收到信息的间隔和信息确认的间隔。PubSubSource 只有在信息被成功快照之后才会确认以保证至少一次的语义。这意味着，如果你的快照间隔大于信息确认的截止时间，那么你订阅的信息很有可能会被多次处理。
Review comment:
Thanks, I will update the english version as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Sxnan commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383665012
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -39,24 +37,17 @@ following dependency to your project:
<b>Note</b>: This connector has been added to Flink recently. It has not received widespread testing yet.
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383103413
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -106,17 +97,18 @@ dataStream.addSink(pubsubSink);
### Google Credentials
-Google uses [Credentials](https://cloud.google.com/docs/authentication/production) to authenticate and authorize applications so that they can use Google Cloud Platform resources (such as PubSub).
+应用程序需要使用 [Credentials](https://cloud.google.com/docs/authentication/production) 来通过认证和授权才能使用 Google Cloud Platform 的资源，例如PubSub。
Review comment:
例如[space]PubSub
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Sxnan commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383667140
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -143,22 +135,22 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### 精确一次语义保证
#### SourceFunction
-There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
+有很多原因导致会一个信息会被多次发出，例如 Google PubSub 的故障。
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+另一个可能的原因是超过了确认的截止时间。这是收到信息的间隔和信息确认的间隔。PubSubSource 只有在信息被成功快照之后才会确认以保证至少一次的语义。这意味着，如果你的快照间隔大于信息确认的截止时间，那么你订阅的信息很有可能会被多次处理。
-For this reason it's recommended to have a (much) lower checkpoint interval than acknowledgement deadline.
+因此，我们建议把快照的间隔设置得比信息确认截止时间更短。
-See [PubSub](https://cloud.google.com/pubsub/docs/subscriber) for details on how to increase the acknowledgment deadline of your subscription.
+参照 [PubSub](https://cloud.google.com/pubsub/docs/subscriber) 来增加信息确认截止时间。
-Note: The metric `PubSubMessagesProcessedNotAcked` shows how many messages are waiting for the next checkpoint before they will be acknowledged.
+注意: `PubSubMessagesProcessedNotAcked` 显示了有多少信息正在等待下一个快照还没被确认。
#### SinkFunction
-The sink function buffers messages that are to be send to PubSub for a short amount of time for performance reasons. Before each checkpoint this buffer is flushed and the checkpoint will not succeed unless the messages have been delivered to PubSub.
+Sink function 会把准备发到 PubSub 的信息短暂地缓存以提高性能。每次快照前，它会 flush 缓冲区，并且只有当所有信息成功发送到 PubSub 之后，快照才会成功完成。
Review comment:
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r398507068
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -36,27 +34,20 @@ following dependency to your project:
{% endhighlight %}
<p style="border-radius: 5px; padding: 5px" class="bg-danger">
-<b>Note</b>: This connector has been added to Flink recently. It has not received widespread testing yet.
+<b>注意</b>：此连接器最近才加到 Flink 里，还未接受广泛测试。
</p>
-Note that the streaming connectors are currently not part of the binary
-distribution. See
-[here]({{ site.baseurl }}/dev/projectsetup/dependencies.html)
-for information about how to package the program with the libraries for
-cluster execution.
-
-
+注意连接器目前还不是二进制发行版的一部分，添加依赖、打包配置以及集群运行信息请参考[这里]({{ site.baseurl }}/dev/projectsetup/dependencies.html)
Review comment:
```suggestion
注意连接器目前还不是二进制发行版的一部分，添加依赖、打包配置以及集群运行信息请参考[这里]({{ site.baseurl }}/zh/dev/projectsetup/dependencies.html)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383102874
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -39,24 +37,17 @@ following dependency to your project:
<b>Note</b>: This connector has been added to Flink recently. It has not received widespread testing yet.
</p>
-Note that the streaming connectors are currently not part of the binary
-distribution. See
-[here]({{ site.baseurl }}/dev/projectsetup/dependencies.html)
-for information about how to package the program with the libraries for
-cluster execution.
-
-
+注意连接器目前还不是二进制发行版的一部分，添加依赖、打包配置以及集群运行信息请参考[这里]({{ site.baseurl }}/dev/projectsetup/dependencies.html)
## Consuming or Producing PubSubMessages
-The connector provides a connectors for receiving and sending messages from and to Google PubSub.
-Google PubSub has an `at-least-once` guarantee and as such the connector delivers the same guarantees.
+连接器可以接收和发送 Google PubSub 的信息。和 Google PubSub 一样，这个连接器能够保证`至少一次`的语义。
### PubSub SourceFunction
-The class `PubSubSource` has a builder to create PubSubsources: `PubSubSource.newBuilder(...)`
+`PubSubSource` 类的对象由构建类来构建: `PubSubSource.newBuilder(...)`
-There are several optional methods to alter how the PubSubSource is created, the bare minimum is to provide a Google project, Pubsub subscription and a way to deserialize the PubSubMessages.
+除了 Google project，Pubsub subscription 和反序列化 PubSubMessage的方法是必须的，你有多种可选的方法来创建 PubSubSource。
Review comment:
I think it's better to be:
有多种可选的方法来创建 PubSubSource，但最低要求是要提供 Google Project、Pubsub 订阅和反序列化 PubSubMessages 的方法。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
Hash:89d26f578174d90ce9979f076346376bf3597a5b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:89d26f578174d90ce9979f076346376bf3597a5b
-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#issuecomment-588760864
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149774919",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "89d26f578174d90ce9979f076346376bf3597a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342",
"triggerID" : "89d26f578174d90ce9979f076346376bf3597a5b",
"triggerType" : "PUSH"
}, {
"hash" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150423224",
"triggerID" : "abb918ce3a00f39036b019a1eeb3e49dd91910b8",
"triggerType" : "PUSH"
}, {
"hash" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45d6384bd0f1017bc126d17bb7fe8e32e12ea488",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89d26f578174d90ce9979f076346376bf3597a5b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149774919) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5342)
* abb918ce3a00f39036b019a1eeb3e49dd91910b8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150423224)
* 45d6384bd0f1017bc126d17bb7fe8e32e12ea488 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383101821
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -39,24 +37,17 @@ following dependency to your project:
<b>Note</b>: This connector has been added to Flink recently. It has not received widespread testing yet.
Review comment:
The note here is not translated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] PatrickRen commented on a change in pull request #11151:
[FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on a change in pull request #11151: [FLINK-16128][docs]Translate "Google Cloud PubSub" page into Chinese
URL: https://github.com/apache/flink/pull/11151#discussion_r383105282
##########
File path: docs/dev/connectors/pubsub.zh.md
##########
@@ -143,22 +135,22 @@ env.addSource(pubsubSource)
</div>
</div>
-### Atleast once guarantee
+### 精确一次语义保证
#### SourceFunction
-There are several reasons why a message might be send multiple times, such as failure scenarios on Google PubSub's side.
+有很多原因导致会一个信息会被多次发出，例如 Google PubSub 的故障。
-Another reason is when the acknowledgement deadline has passed. This is the time between receiving the message and between acknowledging the message. The PubSubSource will only acknowledge a message on successful checkpoints to guarantee Atleast-Once. This does mean if the time between successful checkpoints is larger than the acknowledgment deadline of your subscription messages will most likely be processed multiple times.
+另一个可能的原因是超过了确认的截止时间。这是收到信息的间隔和信息确认的间隔。PubSubSource 只有在信息被成功快照之后才会确认以保证至少一次的语义。这意味着，如果你的快照间隔大于信息确认的截止时间，那么你订阅的信息很有可能会被多次处理。
Review comment:
I doubt that the second "between" is added by mistake in the original English document:
> This is the time between receiving the message and <s>between</s> acknowledging the message.
If so, the translation would be:
另一个可能的原因是超过了确认的截止时间，即收到与确认信息之间的时间间隔。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services