[GitHub] [flink] TisonKun commented on a change in pull request #11639: [FLINK-16626][runtime] Prevent REST handler from being closed more than once

[GitBox <gi...@apache.org>]

TisonKun commented on a change in pull request #11639: [FLINK-16626][runtime] Prevent REST handler from being closed more than once
URL: https://github.com/apache/flink/pull/11639#discussion_r404721269
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java
 ##########
 @@ -221,7 +227,12 @@ private void finalizeRequestProcessing(FileUploads uploadedFiles) {
 
 	@Override
 	public final CompletableFuture<Void> closeAsync() {
-		return FutureUtils.composeAfterwards(closeHandlerAsync(), inFlightRequestTracker::awaitAsync);
+		if (isHandlerClosed.compareAndSet(false, true)) {
+			return FutureUtils.composeAfterwards(closeHandlerAsync(), inFlightRequestTracker::awaitAsync);
+		} else {
+			log.warn("The handler instance for {} had already been closed, but another attempt at closing it was made.", untypedResponseMessageHeaders.getTargetRestEndpointURL());
+			return CompletableFuture.completedFuture(null);
 
 Review comment:
   I don't think we should return a completed future if the handle has received "close" message. It is possible that the handle is still closing. Possibly we alter ``inFlightRequestTracker::awaitAsync` to return the terminate future if it is closed, without deregister the phaser party.
   
   cc @zentol  @GJL 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services