[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2294: Add convert tablet rowset type

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #2294: Add convert tablet rowset type
URL: https://github.com/apache/incubator-doris/pull/2294#discussion_r353052080
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/alter/RollupHandler.java
 ##########
 @@ -406,6 +413,48 @@ public void processDropRollup(DropRollupClause alterClause, Database db, OlapTab
         LOG.info("finished drop rollup index[{}] in table[{}]", rollupIndexName, olapTable.getName());
     }
 
+    // sql: alter table base_table_name set property ("storage_format" = "v2");
 
 Review comment:
   This grammar is confusing. I think that grammar is used to changing all base table to v2 format.
   But is creating rollup actually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org